Bug 122911

Summary:

Implement spread

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eflews.bot, gyuyoung.kim, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

122919

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	msaboff: review+, eflews.bot: commit-queue-

Oliver Hunt

Reported 2013-10-16 12:33:57 PDT

Implement spread

Attachments
Patch (37.17 KB, patch) 2013-10-16 12:40 PDT, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (37.73 KB, patch) 2013-10-16 13:17 PDT, Oliver Hunt	msaboff: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2013-10-16 12:40:42 PDT

Created attachment 214385 [details] Patch

WebKit Commit Bot

Comment 2 2013-10-16 12:43:11 PDT

Attachment 214385 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/js/basic-spread-expected.txt', u'LayoutTests/js/basic-spread.html', u'LayoutTests/js/parser-syntax-check-expected.txt', u'LayoutTests/js/script-tests/basic-spread.js', u'LayoutTests/js/script-tests/parser-syntax-check.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h', u'Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp', u'Source/JavaScriptCore/parser/ASTBuilder.h', u'Source/JavaScriptCore/parser/Lexer.cpp', u'Source/JavaScriptCore/parser/NodeConstructors.h', u'Source/JavaScriptCore/parser/Nodes.h', u'Source/JavaScriptCore/parser/Parser.cpp', u'Source/JavaScriptCore/parser/Parser.h', u'Source/JavaScriptCore/parser/ParserTokens.h', u'Source/JavaScriptCore/parser/SyntaxChecker.h']" exit_code: 1 Source/JavaScriptCore/parser/ParserTokens.h:105: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 3 2013-10-16 12:43:46 PDT

Comment on attachment 214385 [details] Patch Attachment 214385 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3494534

Build Bot

Comment 4 2013-10-16 13:08:24 PDT

Comment on attachment 214385 [details] Patch Attachment 214385 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4113218

Oliver Hunt

Comment 5 2013-10-16 13:17:32 PDT

Created attachment 214388 [details] Patch

WebKit Commit Bot

Comment 6 2013-10-16 13:20:13 PDT

Attachment 214388 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/js/basic-spread-expected.txt', u'LayoutTests/js/basic-spread.html', u'LayoutTests/js/parser-syntax-check-expected.txt', u'LayoutTests/js/script-tests/basic-spread.js', u'LayoutTests/js/script-tests/parser-syntax-check.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h', u'Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp', u'Source/JavaScriptCore/parser/ASTBuilder.h', u'Source/JavaScriptCore/parser/Lexer.cpp', u'Source/JavaScriptCore/parser/NodeConstructors.h', u'Source/JavaScriptCore/parser/Nodes.h', u'Source/JavaScriptCore/parser/Parser.cpp', u'Source/JavaScriptCore/parser/Parser.h', u'Source/JavaScriptCore/parser/ParserTokens.h', u'Source/JavaScriptCore/parser/SyntaxChecker.h']" exit_code: 1 Source/JavaScriptCore/parser/ParserTokens.h:105: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 7 2013-10-16 13:20:27 PDT

Comment on attachment 214388 [details] Patch Attachment 214388 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/4103338

Michael Saboff

Comment 8 2013-10-16 13:48:08 PDT

Comment on attachment 214388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214388&action=review r+ after EFL builds and adding new test case. > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1515 > + Eliminate new white space > LayoutTests/js/basic-spread-expected.txt:95 > + Please add a test with more than one spread.

Build Bot

Comment 9 2013-10-16 13:57:54 PDT

Comment on attachment 214388 [details] Patch Attachment 214388 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/4109371

Oliver Hunt

Comment 10 2013-10-16 14:25:56 PDT

Committed r157529: <http://trac.webkit.org/changeset/157529>

WebKit Commit Bot

Comment 11 2013-10-16 15:27:49 PDT

Re-opened since this is blocked by bug 122919

Alexey Proskuryakov

Comment 12 2013-10-16 16:02:18 PDT

Failures: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/13871/steps/jscore-test/logs/stdio

Oliver Hunt

Comment 13 2013-10-16 18:01:06 PDT

Committed r157545: <http://trac.webkit.org/changeset/157545>

Note You need to log in before you can comment on or make changes to this bug.