Bug 122909

Summary: Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, timothy
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122677    
Attachments:
Description Flags
screenshot
none
patch
none
patch ap: review+

Alexey Proskuryakov
Reported 2013-10-16 11:58:05 PDT
Created attachment 214382 [details] screenshot Especially with checkmarks, this looks fairly bad. I think that there are two issues: - the font is different, making the checkmark look like it's lower; - numbers look good when zoomed in, so it's probably some rounding in layout.
Attachments
screenshot (148.89 KB, image/png)
2013-10-16 11:58 PDT, Alexey Proskuryakov 		no flags
Details
patch (3.08 KB, patch)
2013-11-16 14:37 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (1.80 KB, patch)
2013-11-18 00:56 PST, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-11-16 14:37:20 PST
Created attachment 217135 [details] patch
WebKit Commit Bot
Comment 2 2013-11-16 15:17:09 PST
Comment on attachment 217135 [details] patch Clearing flags on attachment: 217135 Committed r159382: <http://trac.webkit.org/changeset/159382>
WebKit Commit Bot
Comment 3 2013-11-16 15:17:11 PST
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 4 2013-11-18 00:55:59 PST
Reopening for a follow up patch. This can look terrible sometimes when the SVG doesn't load until after the bot data is all loaded... let's data-uri it.
Tim Horton
Comment 5 2013-11-18 00:56:13 PST
Created attachment 217176 [details] patch
Alexey Proskuryakov
Comment 6 2013-11-18 08:35:12 PST
Comment on attachment 217176 [details] patch Should this patch also delete the SVG file?
Tim Horton
Comment 7 2013-11-18 11:30:08 PST
(In reply to comment #6) > (From update of attachment 217176 [details]) > Should this patch also delete the SVG file? I suppose, since it's trivially recoverable from the data URI.
Tim Horton
Comment 8 2013-11-18 11:32:19 PST
http://trac.webkit.org/changeset/159440
Note You need to log in before you can comment on or make changes to this bug.