Bug 122865

Summary:

A page should exit fullscreen mode if it opens a new popup

Product:

WebKit

Reporter:

jochen

Component:

New Bugs

Assignee:

jochen

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, jer.noble, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch	none
Patch	none

jochen

Reported 2013-10-15 14:50:30 PDT

A page should exit fullscreen mode if it opens a new popup

Attachments
Patch (5.52 KB, patch) 2013-10-15 14:51 PDT, jochen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (455.41 KB, application/zip) 2013-10-15 15:38 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (468.09 KB, application/zip) 2013-10-15 15:58 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (470.87 KB, application/zip) 2013-10-15 17:05 PDT, Build Bot	no flags	Details
Patch (14.67 KB, patch) 2013-10-16 10:49 PDT, jochen	no flags	Details Formatted Diff Diff
Patch (14.76 KB, patch) 2013-10-16 14:05 PDT, jochen	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

jochen

Comment 1 2013-10-15 14:51:41 PDT

Created attachment 214303 [details] Patch

Jer Noble

Comment 2 2013-10-15 14:55:01 PDT

Comment on attachment 214303 [details] Patch Looks good so far. Can you add similar code to the WebKit1 code path?

jochen

Comment 3 2013-10-15 14:55:53 PDT

sure. is it ok that the cancelling doesn't send a fullscreen changed signal?

Build Bot

Comment 4 2013-10-15 15:38:01 PDT

Comment on attachment 214303 [details] Patch Attachment 214303 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3744071 New failing tests: fullscreen/full-screen-exit-when-popup.html

Build Bot

Comment 5 2013-10-15 15:38:02 PDT

Created attachment 214311 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2013-10-15 15:58:13 PDT

Comment on attachment 214303 [details] Patch Attachment 214303 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3482115 New failing tests: fullscreen/full-screen-exit-when-popup.html

Build Bot

Comment 7 2013-10-15 15:58:14 PDT

Created attachment 214314 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 8 2013-10-15 17:05:16 PDT

Comment on attachment 214303 [details] Patch Attachment 214303 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4109087 New failing tests: fullscreen/full-screen-exit-when-popup.html

Build Bot

Comment 9 2013-10-15 17:05:18 PDT

Created attachment 214321 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

jochen

Comment 10 2013-10-16 10:49:53 PDT

Created attachment 214374 [details] Patch

jochen

Comment 11 2013-10-16 14:05:38 PDT

Created attachment 214393 [details] Patch

jochen

Comment 12 2013-10-16 14:06:03 PDT

new version that correctly sends fullscreenchanged events PTAL

Jer Noble

Comment 13 2013-10-16 14:13:14 PDT

Comment on attachment 214393 [details] Patch Looks good. r=me.

WebKit Commit Bot

Comment 14 2013-10-16 15:18:39 PDT

Comment on attachment 214393 [details] Patch Clearing flags on attachment: 214393 Committed r157534: <http://trac.webkit.org/changeset/157534>

WebKit Commit Bot

Comment 15 2013-10-16 15:18:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.