Bug 122853
| Summary: | Drop CSS cursor quirk for missing fallback cursor | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, benjamin, kling, koivisto, syoichi |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/db44f7cb06a22c64e63b2dcb35a7a59b858f6c33
IE used to allow URI cursors without a specified pre-defined cursor value
fallback. This CL removes the support for that quirk because IE allegedly
dropped this quirk in IE9, even in the compat modes (see issue 286668).
Made the existing parsing tests run in strict mode and moved test cases for
quirks mode to a new file.
The 'hand' -> 'pointer' quirk was not touched.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
I changed the test case of quirk added in the patch to following JSFiddle:
Link - https://jsfiddle.net/npusjzhm/1/show
It showed following across all browsers:
Test cursor rules which should accept 'hand' as an alias of 'pointer'.
FAIL roundtripCssRule("cursor: hand;") should be cursor: pointer;. Was .
FAIL roundtripCssRule("cursor: url(file:///foo.png), hand;") should be cursor: url(file:///foo.png), pointer;. Was .
Test invalid cursor rules which shouldn't parse at all.
PASS roundtripCssRule("cursor: url(file:///foo.png), url(file:///foo2.png);") is ""
PASS successfullyParsed is true
___
rniwa@webkit.org - is it needed now? or this is resolved? Thanks!
Ryosuke Niwa
We match Blink in this regard now.