Summary: | Add a skeleton Database process for future usage by IDB and Web SQL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, commit-queue, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2013-10-15 11:59:12 PDT
Created attachment 214290 [details]
Patch v1
Enabled for Mac only, right now, and the #ifdef guards should keep other builds as-is. Attachment 214290 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/DatabaseProcess.xcconfig', u'Source/WebKit2/Configurations/DatabaseService.Development.xcconfig', u'Source/WebKit2/Configurations/DatabaseService.xcconfig', u'Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp', u'Source/WebKit2/DatabaseProcess/DatabaseProcess.h', u'Source/WebKit2/DatabaseProcess/EntryPoint/mac/LegacyProcess/DatabaseProcessMain.mm', u'Source/WebKit2/DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist', u'Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist', u'Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist', u'Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm', u'Source/WebKit2/DatabaseProcess/mac/DatabaseProcessMac.mm', u'Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp', u'Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h', u'Source/WebKit2/UIProcess/Databases/mac/DatabaseProcessProxyMac.mm', u'Source/WebKit2/UIProcess/Launcher/ProcessLauncher.cpp', u'Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h', u'Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebKit2Prefix.h']" exit_code: 1
Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:75: Should have a space between // and comment [whitespace/comments] [4]
Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:64: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 2 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Attachment 214290 [details] did not pass style-queue: > > Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:75: Should have a space between // and comment [whitespace/comments] [4] > Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp:64: Should have a space between // and comment [whitespace/comments] [4] Fixed locally. Comment on attachment 214290 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=214290&action=review > Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist:30 > + <key>NSPrincipalClass</key> > + <string>NSApplication</string> I am not sure you want this. > Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist:36 > + <key>JoinExistingSession</key> > + <true/> I am not sure you need this. > Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:28 > + <key>NSPrincipalClass</key> > + <string>NSApplication</string> Do you need this? > Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:36 > + <key>JoinExistingSession</key> > + <true/> Do you need this? |