Summary: | Emphasis marks has wrong color. | ||
---|---|---|---|
Product: | WebKit | Reporter: | peavo |
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, mitz, rniwa |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
peavo
2013-10-15 07:05:01 PDT
Created attachment 214256 [details]
Patch
Hmm did I actually accidentally fix text-emhpasis-color? Emphasis marks seems to be drawn using the stroke colour. With this patch the color has not effect. Comment on attachment 214256 [details]
Patch
Nope, I'm wrong. fast/text/emphasis.html clearly shows this is correct.
r=me, good spotting!
Comment on attachment 214256 [details] Patch Rejecting attachment 214256 [details] from commit-queue. New failing tests: fast/text/text-emphasis.html Full output: http://webkit-queues.appspot.com/results/4100070 Created attachment 214277 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 214256 [details] Patch Attachment 214256 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4111008 New failing tests: fast/text/text-emphasis.html Created attachment 214286 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 214256 [details] Patch Attachment 214256 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4103013 New failing tests: fast/text/text-emphasis.html Created attachment 214293 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 214356 [details]
Patch
Updated patch with new tests, which will hopefully not fail ;) Comment on attachment 214356 [details] Patch Clearing flags on attachment: 214356 Committed r157518: <http://trac.webkit.org/changeset/157518> All reviewed patches have been landed. Closing bug. |