Bug 122792

Summary:

JSC API should move away from using WebKitAvailability macros

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

NEW

Severity:

Normal

CC:

buildbot, commit-queue, eflews.bot, gyuyoung.kim, philn, rniwa, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	mhahnenberg: review-, mhahnenberg: commit-queue-

Mark Hahnenberg

Reported 2013-10-14 17:39:30 PDT

Instead the JSC API should use the OS-provided availability macros.

Attachments
Patch (9.54 KB, patch) 2013-10-14 17:44 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (9.97 KB, patch) 2013-10-14 17:52 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Patch (18.49 KB, patch) 2013-10-14 18:43 PDT, Mark Hahnenberg	mhahnenberg: review- mhahnenberg: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2013-10-14 17:44:58 PDT

Created attachment 214211 [details] Patch

WebKit Commit Bot

Comment 2 2013-10-14 17:46:17 PDT

Attachment 214211 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBasePrivate.h', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/API/JSContextRefPrivate.h', u'Source/JavaScriptCore/API/JSObjectRef.h', u'Source/JavaScriptCore/API/JSValueRef.h', u'Source/JavaScriptCore/ChangeLog']" exit_code: 1 Source/JavaScriptCore/API/JSValueRef.h:221: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSValueRef.h:232: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSBasePrivate.h:46: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSContextRef.h:59: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSContextRef.h:66: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSContextRef.h:95: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 3 2013-10-14 17:49:43 PDT

Comment on attachment 214211 [details] Patch Attachment 214211 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/4060010

Mark Hahnenberg

Comment 4 2013-10-14 17:52:14 PDT

Created attachment 214212 [details] Patch

WebKit Commit Bot

Comment 5 2013-10-14 17:52:49 PDT

Attachment 214212 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBasePrivate.h', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/API/JSContextRefPrivate.h', u'Source/JavaScriptCore/API/JSObjectRef.h', u'Source/JavaScriptCore/API/JSValueRef.h', u'Source/JavaScriptCore/API/WebKitAvailability.h', u'Source/JavaScriptCore/ChangeLog']" exit_code: 1 Source/JavaScriptCore/API/JSValueRef.h:221: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSValueRef.h:232: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSBasePrivate.h:46: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSContextRef.h:59: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSContextRef.h:66: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/API/JSContextRef.h:95: The parameter name "group" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 6 2013-10-14 18:17:01 PDT

Comment on attachment 214212 [details] Patch Attachment 214212 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3461050

Build Bot

Comment 7 2013-10-14 18:37:27 PDT

Comment on attachment 214212 [details] Patch Attachment 214212 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4039012

Mark Hahnenberg

Comment 8 2013-10-14 18:43:54 PDT

Created attachment 214217 [details] Patch

Mark Hahnenberg

Comment 9 2013-10-14 18:44:41 PDT

Comment on attachment 214217 [details] Patch Posted to wrong bug :-/

Note You need to log in before you can comment on or make changes to this bug.