Summary: | Assertion failure in Range::processContentsBetweenOffsets | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, ap, commit-queue, darin, esprehn+autocc, kangil.han, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-10-14 14:26:55 PDT
Created attachment 214189 [details]
Fixes the bug
Comment on attachment 214189 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=214189&action=review > Source/WebCore/dom/Range.cpp:792 > + startOffset = std::min(startOffset, endOffset); The Blink patch didn't adjust startOffset so I'm doing that here. > Source/WebCore/dom/Range.cpp:807 > + startOffset = std::min(startOffset, endOffset); Ditto. > LayoutTests/fast/dom/Range/range-delete-contents-mutation-event-crash-expected.txt:1 > +This tests inserting a text node while calling deleteContents. WebKit should not hit an assertion. I added this description. > LayoutTests/fast/dom/Range/range-delete-contents-mutation-event-crash.html:11 > +var sample = document.getElementById('sample'); And got rid of obnoxious $ function. Created attachment 214191 [details]
Updated for ToT
Committed r157431: <http://trac.webkit.org/changeset/157431> |