Bug 122726

Summary: Move setPseudoStyle() to RenderImage (from RenderElement.)
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kangil.han, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2013-10-13 05:53:04 PDT 
Move setPseudoStyle() to RenderImage (from RenderElement.)
Comment 1 Andreas Kling 2013-10-13 05:53:35 PDT 
Created attachment 214098 [details]
Patch
Comment 2 Antti Koivisto 2013-10-13 06:00:52 PDT 
Comment on attachment 214098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214098&action=review

> Source/WebCore/rendering/RenderImage.cpp:79
> +void RenderImage::setPseudoStyle(PassRefPtr<RenderStyle> pseudoStyle)

I thought we were getting rid of PassRefPtr
Comment 3 Antti Koivisto 2013-10-13 06:03:02 PDT 
Comment on attachment 214098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214098&action=review

> Source/WebCore/rendering/RenderImage.cpp:86
> +    RefPtr<RenderStyle> style = RenderStyle::create();

auto
Comment 4 WebKit Commit Bot 2013-10-13 08:55:06 PDT 
Comment on attachment 214098 [details]
Patch

Clearing flags on attachment: 214098

Committed r157371: <http://trac.webkit.org/changeset/157371>
Comment 5 WebKit Commit Bot 2013-10-13 08:55:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2013-10-13 14:01:47 PDT 
Comment on attachment 214098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214098&action=review

>> Source/WebCore/rendering/RenderImage.cpp:79
>> +void RenderImage::setPseudoStyle(PassRefPtr<RenderStyle> pseudoStyle)
> 
> I thought we were getting rid of PassRefPtr

For return values there is no reason to use it any more. For arguments we have not yet figured out our new approach. But regardless of that, this function does not need a PassRefPtr. It doesn’t seem to take ownership at all.