Bug 122722

Summary: Make absoluteQuads/Rects functions return Vectors
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, cmarcelo, commit-queue, dmazzoni, esprehn+autocc, glenn, jdiggs, kangil.han, kondapallykalyan, mario
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2013-10-13 03:34:11 PDT
instead of collecting to Vectors.
Attachments
patch (19.03 KB, patch)
2013-10-13 03:48 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-10-13 03:48:15 PDT
Created attachment 214095 [details] patch
Andreas Kling
Comment 2 2013-10-13 03:55:40 PDT
Comment on attachment 214095 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=214095&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS! > Source/WebCore/dom/Range.cpp:1944 > + Vector<FloatQuad> textQuads = renderText.absoluteQuadsForRange(startOffset, endOffset); Could use auto for this. > Source/WebCore/dom/Range.cpp:1947 > quads.appendVector(textQuads); Sidenote: I wonder if an appendVector(Vector&&) would be a useful optimization. > Source/WebCore/rendering/RenderText.cpp:261 > void RenderText::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const I wish this method were called collectAbsoluteRects() or something like that. Same whine for the other similarly named ones.
Antti Koivisto
Comment 3 2013-10-13 04:04:24 PDT
https://trac.webkit.org/r157366
Note You need to log in before you can comment on or make changes to this bug.