Bug 122709

Summary:

Move querySelector from Node to ContainerNode and use references instead of pointers

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

DOM

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, buildbot, cmarcelo, commit-queue, esprehn+autocc, kangil.han, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Patch	andersca: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none

Darin Adler

Reported 2013-10-12 18:10:36 PDT

Move querySelector from Node to ContainerNode and use references instead of pointers

Attachments
Patch (37.31 KB, patch) 2013-10-12 18:42 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (473.86 KB, application/zip) 2013-10-12 20:09 PDT, Build Bot	no flags	Details
Patch (37.71 KB, patch) 2013-10-12 20:21 PDT, Darin Adler	andersca: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (466.46 KB, application/zip) 2013-10-12 21:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (478.40 KB, application/zip) 2013-10-12 21:58 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (454.10 KB, application/zip) 2013-10-12 22:15 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2013-10-12 18:42:21 PDT

Created attachment 214075 [details] Patch

Build Bot

Comment 2 2013-10-12 20:09:38 PDT

Comment on attachment 214075 [details] Patch Attachment 214075 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3776533 New failing tests: inspector-protocol/dom/focus.html inspector-protocol/layers/layers-for-node.html

Build Bot

Comment 3 2013-10-12 20:09:40 PDT

Created attachment 214076 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Darin Adler

Comment 4 2013-10-12 20:21:04 PDT

Created attachment 214077 [details] Patch

Darin Adler

Comment 5 2013-10-12 20:22:03 PDT

Test failed because I had a backwards branch in the inspector part of this patch.

Build Bot

Comment 6 2013-10-12 21:28:33 PDT

Comment on attachment 214077 [details] Patch Attachment 214077 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3948419 New failing tests: inspector-protocol/dom/focus.html inspector-protocol/layers/layers-for-node.html

Build Bot

Comment 7 2013-10-12 21:28:35 PDT

Created attachment 214080 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 8 2013-10-12 21:58:23 PDT

Comment on attachment 214077 [details] Patch Attachment 214077 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3948421 New failing tests: inspector-protocol/dom/focus.html inspector-protocol/layers/layers-for-node.html

Build Bot

Comment 9 2013-10-12 21:58:26 PDT

Created attachment 214081 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 10 2013-10-12 22:15:45 PDT

Comment on attachment 214077 [details] Patch Attachment 214077 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3953491 New failing tests: inspector-protocol/dom/focus.html inspector-protocol/layers/layers-for-node.html

Build Bot

Comment 11 2013-10-12 22:15:47 PDT

Created attachment 214082 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Darin Adler

Comment 12 2013-10-12 22:41:15 PDT

Committed r157354: <http://trac.webkit.org/changeset/157354>

Note You need to log in before you can comment on or make changes to this bug.