Bug 122700

Summary:

[Soup] The NeverDestroyed<std::unique_ptr<NetworkStorageSession>> variable in defaultSession() should be static

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, danw, darin, gustavo, mrobinson, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2013-10-12 13:46:00 PDT

[Soup] The NeverDestroyed<std::unique_ptr<NetworkStorageSession>> variable in defaultSession() should be static

Comment 1 Zan Dobersek 2013-10-12 13:51:58 PDT

Created attachment 214064 [details]
Patch

Comment 2 Zan Dobersek 2013-10-12 14:13:23 PDT

Comment on attachment 214064 [details]
Patch

Clearing flags on attachment: 214064

Committed r157347: <http://trac.webkit.org/changeset/157347>

Comment 3 Zan Dobersek 2013-10-12 14:13:30 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Darin Adler 2013-10-12 15:17:05 PDT

Oops, did I forget the "static" in any other NeverDestroyed lines? Someone should check with grep.

Comment 5 Zan Dobersek 2013-10-12 23:06:58 PDT

No, all NeverDestroyed declarations are now static.