build.webkit.org/dashboard should provide a way to focus on a subset of bots

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

It is beneficial for a bot watcher to only see red result for bots they are actively maintaining - then it's possible to check the current state with a glance, and not think about it.

It would be nice to have an ability to hide bots that are not relevant at the moment.

Not even sure if this needs to be stored as a persistent preference, just adjusting the currently open window might be enough.

[Alexey Proskuryakov]

Probably not a huge issue today. Will become more important as more bots are added though.

[Tim Horton]

Created attachment 217025 [details]
patch

I super-duper don't know how to JavaScript, so I'd love some help.

[Tim Horton]

Created attachment 217026 [details]
patch

[Tim Horton]

Created attachment 217034 [details]
screenshot, before hiding

[Tim Horton]

Created attachment 217035 [details]
screenshot, after hiding

[Timothy Hatcher]

Comment on attachment 217026 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217026&action=review

Otherwise looks good.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:74
> +    applyHiddenPlatforms: function()

It seems odd to have this here. It touches stuff only the main script should.

[Alexey Proskuryakov]

Comment on attachment 217026 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217026&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:86
> +    var unhideButton = document.createElement("a");

It probably doesn't matter in practice, but abusing <a> to implement a button doesn't seem great or necessary.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:88
> +    unhideButton.textContent = "Clear Hidden Platforms";

Maybe "Show all platforms"? Looking at the screenshot, I was unsure whether this link cleared results for hidden platforms or something.

[Tim Horton]

Created attachment 217068 [details]
address xenon + al's comments

[Tim Horton]

http://trac.webkit.org/changeset/159352