Bug 122676

Summary: build.webkit.org/dashboard should provide a way to focus on a subset of bots
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Enhancement CC: thorton, timothy
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
timothy: review-
screenshot, before hiding
screenshot, after hiding
address xenon + al's comments timothy: review+

Description Alexey Proskuryakov 2013-10-11 13:09:34 PDT
It is beneficial for a bot watcher to only see red result for bots they are actively maintaining - then it's possible to check the current state with a glance, and not think about it.

It would be nice to have an ability to hide bots that are not relevant at the moment.

Not even sure if this needs to be stored as a persistent preference, just adjusting the currently open window might be enough.
Comment 1 Alexey Proskuryakov 2013-10-16 10:43:41 PDT
Probably not a huge issue today. Will become more important as more bots are added though.
Comment 2 Tim Horton 2013-11-15 01:56:48 PST
Created attachment 217025 [details]

I super-duper don't know how to JavaScript, so I'd love some help.
Comment 3 Tim Horton 2013-11-15 01:59:32 PST
Created attachment 217026 [details]
Comment 4 Tim Horton 2013-11-15 02:49:40 PST
Created attachment 217034 [details]
screenshot, before hiding
Comment 5 Tim Horton 2013-11-15 02:49:54 PST
Created attachment 217035 [details]
screenshot, after hiding
Comment 6 Timothy Hatcher 2013-11-15 08:27:55 PST
Comment on attachment 217026 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=217026&action=review

Otherwise looks good.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:74
> +    applyHiddenPlatforms: function()

It seems odd to have this here. It touches stuff only the main script should.
Comment 7 Alexey Proskuryakov 2013-11-15 08:35:28 PST
Comment on attachment 217026 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=217026&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:86
> +    var unhideButton = document.createElement("a");

It probably doesn't matter in practice, but abusing <a> to implement a button doesn't seem great or necessary.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:88
> +    unhideButton.textContent = "Clear Hidden Platforms";

Maybe "Show all platforms"? Looking at the screenshot, I was unsure whether this link cleared results for hidden platforms or something.
Comment 8 Tim Horton 2013-11-15 12:10:12 PST
Created attachment 217068 [details]
address xenon + al's comments
Comment 9 Tim Horton 2013-11-15 12:26:13 PST