Bug 122648 – Assertion failure in -[WebBasePluginPackage dealloc] when two symlinks point to the same plugin

• Component: Plug-ins
• Status: RESOLVED WONTFIX

[Adam Roben (:aroben)]

My /Library/Internet Plug-Ins contains this:

lrwxr-xr-x  1 root    wheel    92 Jul 18  2012 AmazonMP3DownloaderPlugin.plugin -> /Applications/Amazon MP3 Downloader.app/Contents/Resources//AmazonMP3DownloaderPlugin.plugin
lrwxr-xr-x  1 root  wheel  91 Aug  7  2012 AmazonMP3DownloaderPlugin1017265.plugin -> /Applications/Amazon MP3 Downloader.app/Contents/Resources/AmazonMP3DownloaderPlugin.plugin

This causes an assertion failure in -[WebBasePluginPackage dealloc]:

    ASSERT(!pluginDatabases || [pluginDatabases count] == 0);

0   com.apple.JavaScriptCore      	0x000000010ee3d2fa WTFCrash + 42 (Assertions.cpp:342)
1   com.apple.WebKit              	0x000000010ff8358b -[WebBasePluginPackage dealloc] + 123 (WebBasePluginPackage.mm:273)
2   com.apple.CoreFoundation      	0x00007fff91d6228a CFRelease + 170
3   com.apple.CoreFoundation      	0x00007fff91e85e35 -[__NSSetM dealloc] + 117
4   libobjc.A.dylib               	0x00007fff9223d230 (anonymous namespace)::AutoreleasePoolPage::pop(void*) + 464
5   com.apple.CoreFoundation      	0x00007fff91d89d72 _CFAutoreleasePoolPop + 34
6   com.apple.Foundation          	0x00007fff9527847a -[NSAutoreleasePool drain] + 154
7   com.apple.WebKit              	0x000000011007949b -[WebPluginDatabase refresh] + 1355 (WebPluginDatabase.mm:320)
8   com.apple.WebKit              	0x000000011007881c +[WebPluginDatabase sharedDatabase] + 172 (WebPluginDatabase.mm:72)
9   DumpRenderTree                	0x000000010e708b2a addTestPluginsToPluginSearchPath(char const*) + 154 (DumpRenderTree.mm:839)
10  DumpRenderTree                	0x000000010e7085ef dumpRenderTree(int, char const**) + 47 (DumpRenderTree.mm:891)
11  DumpRenderTree                	0x000000010e70a9c8 main + 296 (DumpRenderTree.mm:959)
12  libdyld.dylib                 	0x00007fff8f6b07e1 start + 1

I believe this assertion is harmless in this case. The plugin is not actually part of any plugin database, despite thinking it is; -[WebPluginDatabase _addPlugin:] ensures that we only have one plugin for each canonical path.

I'm working on a patch and test for this.

[Adam Roben (:aroben)]

Created attachment 213991 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 213991 [details]
Patch

Rejecting attachment 213991 [details] from commit-queue.

New failing tests:
userscripts/user-script-audio-document.html
media/video-controls-in-media-document.html
http/tests/media/media-document.html
webarchive/loading/video-in-webarchive.html
userscripts/user-script-video-document.html
media/video-document-types.html
media/video-element-other-namespace-crash.html
media/video-click-dblckick-standalone.html
fast/events/media-focus-in-standalone-media-document.html
media/media-document-audio-size.html
Full output: http://webkit-queues.appspot.com/results/3766209

[WebKit Commit Bot]

Created attachment 213999 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 213991 [details]
Patch

Attachment 213991 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3950164

New failing tests:
userscripts/user-script-audio-document.html
media/video-controls-in-media-document.html
http/tests/media/media-document.html
webarchive/loading/video-in-webarchive.html
userscripts/user-script-video-document.html
media/video-document-types.html
media/video-element-other-namespace-crash.html
media/video-click-dblckick-standalone.html
fast/events/media-focus-in-standalone-media-document.html
media/media-document-audio-size.html

[Build Bot]

Created attachment 214000 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 213991 [details]
Patch

Attachment 213991 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3867239

New failing tests:
userscripts/user-script-audio-document.html
media/video-controls-in-media-document.html
http/tests/media/media-document.html
webarchive/loading/video-in-webarchive.html
userscripts/user-script-video-document.html
media/video-document-types.html
media/video-element-other-namespace-crash.html
media/video-click-dblckick-standalone.html
fast/events/media-focus-in-standalone-media-document.html
media/media-document-audio-size.html

[Build Bot]

Created attachment 214002 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 213991 [details]
Patch

Attachment 213991 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3403296

New failing tests:
userscripts/user-script-audio-document.html
media/video-controls-in-media-document.html
http/tests/media/media-document.html
webarchive/loading/video-in-webarchive.html
userscripts/user-script-video-document.html
media/video-document-types.html
media/video-element-other-namespace-crash.html
media/video-click-dblckick-standalone.html
fast/events/media-focus-in-standalone-media-document.html
media/media-document-audio-size.html

[Build Bot]

Created attachment 214011 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Alexey Proskuryakov]

Mass closing plug-in bugs, as plug-in support has been removed from WebKit.

Please comment and/or reopen if this still affects WebKit in some way.