Bug 122630

Summary:

Add toSVGColor|Paint() to cleanup static_cast<>, and use it

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

CSS

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, macpherson, menard, pdr, schenney

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Gyuyoung Kim

Reported 2013-10-10 19:22:43 PDT

SVGColor and SVGPaint can't use CSS_VALUE_TYPE_CASTS(), this cl adds toSVGColor() and toSVGPaint() manually. Those functions will help to detect bad type cast.

Attachments
Patch (7.03 KB, patch) 2013-10-10 19:26 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2013-10-10 19:26:13 PDT

Created attachment 213955 [details] Patch

WebKit Commit Bot

Comment 2 2013-10-10 20:35:48 PDT

Comment on attachment 213955 [details] Patch Clearing flags on attachment: 213955 Committed r157286: <http://trac.webkit.org/changeset/157286>

WebKit Commit Bot

Comment 3 2013-10-10 20:35:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.