Bug 122612

Summary:

Making the base implementation of isAudioStreamSource, in MediaStreamSource, return the correct value

Product:

WebKit

Reporter:

Thiago de Barros Lacerda <thiago.lacerda>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, hta, jer.noble, mrobinson, pnormand, tommyw

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Thiago de Barros Lacerda 2013-10-10 12:01:00 PDT

There is no reason for this implementation, in the base class, to always return false if we already have the information about the type of the source.

Comment 1 Thiago de Barros Lacerda 2013-10-10 12:06:14 PDT

Created attachment 213911 [details]
Patch

Comment 2 Jer Noble 2013-10-10 15:25:10 PDT

This is great, but it doesn't go far enough. :)

Could you also remove the isAudioStreamSource() method from MediaStreamAudioSource and make this method non-virtual?

Comment 3 Thiago de Barros Lacerda 2013-10-10 17:00:25 PDT

Created attachment 213948 [details]
Patch

Comment 4 Jer Noble 2013-10-10 17:13:26 PDT

Comment on attachment 213948 [details]
Patch

r=me.

Comment 5 WebKit Commit Bot 2013-10-10 17:39:23 PDT

Comment on attachment 213948 [details]
Patch

Clearing flags on attachment: 213948

Committed r157280: <http://trac.webkit.org/changeset/157280>

Comment 6 WebKit Commit Bot 2013-10-10 17:39:26 PDT

All reviewed patches have been landed.  Closing bug.