Bug 122612

Summary:

Making the base implementation of isAudioStreamSource, in MediaStreamSource, return the correct value

Product:

WebKit

Reporter:

Thiago de Barros Lacerda <thiago.lacerda>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, hta, jer.noble, mrobinson, pnormand, tommyw

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Thiago de Barros Lacerda

Reported 2013-10-10 12:01:00 PDT

There is no reason for this implementation, in the base class, to always return false if we already have the information about the type of the source.

Attachments
Patch (1.59 KB, patch) 2013-10-10 12:06 PDT, Thiago de Barros Lacerda	no flags	Details Formatted Diff Diff
Patch (2.30 KB, patch) 2013-10-10 17:00 PDT, Thiago de Barros Lacerda	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Thiago de Barros Lacerda

Comment 1 2013-10-10 12:06:14 PDT

Created attachment 213911 [details] Patch

Jer Noble

Comment 2 2013-10-10 15:25:10 PDT

This is great, but it doesn't go far enough. :) Could you also remove the isAudioStreamSource() method from MediaStreamAudioSource and make this method non-virtual?

Thiago de Barros Lacerda

Comment 3 2013-10-10 17:00:25 PDT

Created attachment 213948 [details] Patch

Jer Noble

Comment 4 2013-10-10 17:13:26 PDT

Comment on attachment 213948 [details] Patch r=me.

WebKit Commit Bot

Comment 5 2013-10-10 17:39:23 PDT

Comment on attachment 213948 [details] Patch Clearing flags on attachment: 213948 Committed r157280: <http://trac.webkit.org/changeset/157280>

WebKit Commit Bot

Comment 6 2013-10-10 17:39:26 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.