Bug 12260 – Windows platform build is not maintained

• Component: Platform
• Status: RESOLVED FIXED

[Laszlo Gombos]

Windows platform  build is not maintained

[Laszlo Gombos]

Created attachment 12422 [details]
Various fixes to make sure the Windows port compiles.

Various fixes to make sure the Windows port compiles. This still leaves some (~20) linking error unresolved.

[Alexey Proskuryakov]

Comment on attachment 12422 [details]
Various fixes to make sure the Windows port compiles.

 }
-
 void FrameLoader::submitForm(const FrameLoadRequest& request, Event*)

    There should be blank lines between functions.

-        virtual bool canTakeFocus(FocusDirection) = 0;
-        virtual void takeFocus(FocusDirection) = 0;
+        virtual bool canTakeFocus(WebCore::FocusDirection) = 0;
+        virtual void takeFocus(WebCore::FocusDirection) = 0;

    The whole ChromeClient class declaration is in WebCore namespace, so this shouldn't be needed (same with ContextMenuClient).

+bool ChromeClientWin::canTakeFocus (WebCore::FocusDirection)

    There should be no space after canTakeFocus.

+    notImplemented();
+	return false;

    The patch has a lot of tabs - please replace them with spaces.

 }
 
+
+void WebFrameLoaderClient::assignIdentifierToInitialRequest(unsigned long, WebCore::DocumentLoader*, const WebCore::ResourceRequest&)

    Why did you add this blank line?

    Please include a ChangeLog with the patch.

  r- for the style issues. What are the remaining link errors?

[Laszlo Gombos]

Created attachment 12429 [details]
Various fixes to make sure the Windows port compiles

Thanks for the review. I made the suggested changes + some additional fixes I found.

The remaining link errors on Win platform:

webcore.lib(FrameLoader.obj) : error LNK2001: unresolved external symbol "public: static void __cdecl WebCore::ResourceHandle::loadResourceSynchronously(struct WebCore::ResourceRequest const &,class WebCore::ResourceError &,class WebCore::ResourceResponse &,class WTF::Vector<char,0> &)" (?loadResourceSynchronously@ResourceHandle@WebCore@@SAXABUResourceRequest@2@AAVResourceError@2@AAVResourceResponse@2@AAV?$Vector@D$0A@@WTF@@@Z)
webcore.lib(FrameLoader.obj) : error LNK2001: unresolved external symbol "public: bool __thiscall WebCore::DocumentLoader::getResponseModifiedHeader(class WebCore::String &)const " (?getResponseModifiedHeader@DocumentLoader@WebCore@@QBE_NAAVString@2@@Z)
webcore.lib(SubresourceLoader.obj) : error LNK2001: unresolved external symbol "public: unsigned int __thiscall WebCore::SharedBuffer::size(void)const " (?size@SharedBuffer@WebCore@@QBEIXZ)
webcore.lib(SubresourceLoader.obj) : error LNK2001: unresolved external symbol "public: char const * __thiscall WebCore::SharedBuffer::data(void)const " (?data@SharedBuffer@WebCore@@QBEPBDXZ)
webcore.lib(RenderObject.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::GraphicsContext::clipOut(class WebCore::IntRect const &)" (?clipOut@GraphicsContext@WebCore@@QAEXABVIntRect@2@@Z)
webcore.lib(RenderObject.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::GraphicsContext::fillRoundedRect(class WebCore::IntRect const &,class WebCore::IntSize const &,class WebCore::IntSize const &,class WebCore::IntSize const &,class WebCore::IntSize const &,class WebCore::Color const &)" (?fillRoundedRect@GraphicsContext@WebCore@@QAEXABVIntRect@2@ABVIntSize@2@111ABVColor@2@@Z)
webcore.lib(DocumentLoader.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::FrameLoader::didChangeTitle(class WebCore::DocumentLoader *)" (?didChangeTitle@FrameLoader@WebCore@@QAEXPAVDocumentLoader@2@@Z)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::ResourceHandle::setDefersLoading(bool)" (?setDefersLoading@ResourceHandle@WebCore@@QAEX_N@Z)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol "public: static bool __cdecl WebCore::ResourceHandle::supportsBufferedData(void)" (?supportsBufferedData@ResourceHandle@WebCore@@SA_NXZ)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol "public: class WTF::PassRefPtr<class WebCore::SharedBuffer> __thiscall WebCore::ResourceHandle::bufferedData(void)" (?bufferedData@ResourceHandle@WebCore@@QAE?AV?$PassRefPtr@VSharedBuffer@WebCore@@@WTF@@XZ)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::SharedBuffer::clear(void)" (?clear@SharedBuffer@WebCore@@QAEXXZ)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::SharedBuffer::append(char const *,int)" (?append@SharedBuffer@WebCore@@QAEXPBDH@Z)
webcore.lib(ResourceLoader.obj) : error LNK2001: unresolved external symbol "public: __thiscall WebCore::SharedBuffer::SharedBuffer(char const *,int)" (??0SharedBuffer@WebCore@@QAE@PBDH@Z)
webcore.lib(GraphicsContext.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::GraphicsContext::clipOutEllipseInRect(class WebCore::IntRect const &)" (?clipOutEllipseInRect@GraphicsContext@WebCore@@QAEXABVIntRect@2@@Z)
webcore.lib(ContextMenuController.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::ContextMenu::setPlatformDescription(struct HMENU__ *)" (?setPlatformDescription@ContextMenu@WebCore@@QAEXPAUHMENU__@@@Z)
webcore.lib(ResourceHandle.obj) : error LNK2001: unresolved external symbol "public: void __thiscall WebCore::AuthenticationChallenge::nullify(void)" (?nullify@AuthenticationChallenge@WebCore@@QAEXXZ)
webcore.lib(ResourceHandle.obj) : error LNK2001: unresolved external symbol "public: __thiscall WebCore::AuthenticationChallenge::AuthenticationChallenge(void)" (??0AuthenticationChallenge@WebCore@@QAE@XZ)
G:\WebKitBuild\Release\WebKitWin\WebKit.dll : fatal error LNK1120: 17 unresolved externals

[Adam Roben (:aroben)]

Comment on attachment 12429 [details]
Various fixes to make sure the Windows port compiles

Looks good, although could be out of date by now. r=me

[David Kilzer (:ddkilzer)]

Committed revision 19195.  Removed tab from WebKit/COM/ChromeClientWin.h and added ChangeLogs.