Bug 122598

Summary: CTTE: activeDOMWindow() and firstDOMWindow() should return references.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eflews.bot, gyuyoung.kim, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+, eflews.bot: commit-queue-
Patch none

Andreas Kling
Reported 2013-10-10 07:51:00 PDT
CTTE: activeDOMWindow() and firstDOMWindow() should return references.
Attachments
Patch (26.97 KB, patch)
2013-10-10 07:53 PDT, Andreas Kling 		andersca: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (27.65 KB, patch)
2013-10-10 08:58 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-10 07:53:35 PDT
Created attachment 213883 [details] Patch
Anders Carlsson
Comment 2 2013-10-10 07:55:50 PDT
Comment on attachment 213883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213883&action=review > Source/WebCore/page/DOMWindow.cpp:1832 > +bool DOMWindow::isInsecureScriptAccess(DOMWindow& activeWindow, const String& urlString) Can this be const?
EFL EWS Bot
Comment 3 2013-10-10 08:10:56 PDT
Comment on attachment 213883 [details] Patch Attachment 213883 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3879029
EFL EWS Bot
Comment 4 2013-10-10 08:14:16 PDT
Comment on attachment 213883 [details] Patch Attachment 213883 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3867029
Build Bot
Comment 5 2013-10-10 08:35:21 PDT
Comment on attachment 213883 [details] Patch Attachment 213883 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3872027
Build Bot
Comment 6 2013-10-10 08:36:06 PDT
Comment on attachment 213883 [details] Patch Attachment 213883 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3869029
Build Bot
Comment 7 2013-10-10 08:55:26 PDT
Comment on attachment 213883 [details] Patch Attachment 213883 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3870036
Andreas Kling
Comment 8 2013-10-10 08:58:51 PDT
Created attachment 213889 [details] Patch
WebKit Commit Bot
Comment 9 2013-10-10 09:29:55 PDT
Comment on attachment 213889 [details] Patch Clearing flags on attachment: 213889 Committed r157228: <http://trac.webkit.org/changeset/157228>
WebKit Commit Bot
Comment 10 2013-10-10 09:29:58 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 11 2013-10-10 13:09:35 PDT
(In reply to comment #9) > (From update of attachment 213889 [details]) > Clearing flags on attachment: 213889 > > Committed r157228: <http://trac.webkit.org/changeset/157228> FYI: This patch broke the Apple Windows build, as the EWS noticed it: 1>WebKit.exp : error LNK2001: unresolved external symbol "public: class WTF::PassRefPtr<class WebCore::DOMWindow> __thiscall WebCore::DOMWindow::open(class WTF::String const &,class WTF::AtomicString const &,class WTF::String const &,class WebCore::DOMWindow *,class WebCore::DOMWindow *)" (?open@DOMWindow@WebCore@@QAE?AV?$PassRefPtr@VDOMWindow@WebCore@@@WTF@@ABVString@4@ABVAtomicString@4@0PAV12@2@Z) 1>C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\bin32\WebKit.dll : fatal error LNK1120: 1 unresolved externals
Note You need to log in before you can comment on or make changes to this bug.