Bug 122539

Summary: Rename EventRetargeter::adjustForRelatedTarget to EventPath::setRelatedTarget
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue, darin, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kangil.han, kling, koivisto, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Cleanup darin: review+

Ryosuke Niwa
Reported 2013-10-08 20:11:17 PDT
Rename EventRetargeter::adjustForRelatedTarget to EventPath::setRelatedTarget
Attachments
Cleanup (20.91 KB, patch)
2013-10-08 20:22 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Cleanup (22.83 KB, patch)
2013-10-08 20:49 PDT, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-10-08 20:22:33 PDT
Created attachment 213747 [details] Cleanup
Ryosuke Niwa
Comment 2 2013-10-08 20:31:14 PDT
Comment on attachment 213747 [details] Cleanup Actually, it's cleaner if we made relatedTarget() virtual.
Ryosuke Niwa
Comment 3 2013-10-08 20:49:03 PDT
Created attachment 213748 [details] Cleanup
Darin Adler
Comment 4 2013-10-08 22:20:39 PDT
Comment on attachment 213748 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=213748&action=review > Source/WebCore/dom/Event.h:175 > + virtual EventTarget* relatedTarget() const { return 0; } nullptr > Source/WebCore/dom/MouseEvent.cpp:210 > + return target ? target->toNode() : 0; nullptr But also, not sure why you are putting this into a local variable and not putting target() below into one. It’s especially confusing to put this into a local variable named target, when there’s a function by that name that would return something different. > Source/WebCore/dom/MouseEvent.cpp:213 > return target() ? target()->toNode() : 0; nullptr > Source/WebCore/dom/MouseEvent.cpp:221 > + return target ? target->toNode() : 0; nullptr > Source/WebCore/dom/MouseEvent.cpp:224 > return target() ? target()->toNode() : 0; nullptr
Ryosuke Niwa
Comment 5 2013-10-09 13:04:03 PDT
Committed r157177: <http://trac.webkit.org/changeset/157177>
Note You need to log in before you can comment on or make changes to this bug.