Bug 122520 – WebProcess crash on SAP WebCycle web app

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

WebProcess crash on SAP WebCycle web app

[Anders Carlsson]

Created attachment 213714 [details]
Patch

[Darin Adler]

Comment on attachment 213714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213714&action=review

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:509
> +    NSEvent *event = [NSEvent otherEventWithType:NSApplicationDefined
> +                                        location:NSMakePoint(0, 0)
> +                                   modifierFlags:0
> +                                       timestamp:0.0
> +                                     windowNumber:0
> +                                         context:nil
> +                                         subtype: 0
> +                                           data1:0
> +                                           data2:0];

Would be nice to format this in a less high-maintenance way without the lined up colons. Also, subtype has a space after it.

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:224
> +    ASSERT([NSApp isRunning]);
> +    [NSApp stop:nil];
> +    NSEvent *event = [NSEvent otherEventWithType:NSApplicationDefined
> +                                        location:NSMakePoint(0, 0)
> +                                   modifierFlags:0
> +                                       timestamp:0.0
> +                                     windowNumber:0
> +                                         context:nil
> +                                         subtype: 0
> +                                           data1:0
> +                                           data2:0];
> +    [NSApp postEvent:event atStart:true];

Should share this code with PluginProcess::stopRunLoop.

[Anders Carlsson]

Committed r157137: <http://trac.webkit.org/changeset/157137>