Bug 122519 – Fix ruby LoadError when running run-javascriptcore-tests

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Lam]

On MountainLion running ruby 1.8.7, run-javascriptcore-tests produced the following error:

Running: /usr/bin/env ruby Tools/Scripts/run-jsc-stress-tests -j /Volumes/Data/ws7/OpenSource/WebKitBuild/Debug/jsc -o /Volumes/Data/ws7/OpenSource/WebKitBuild/Debug/jsc-stress-results PerformanceTests/SunSpider/tests/sunspider-1.0 PerformanceTests/SunSpider/tests/v8-v6 Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml LayoutTests/js/regress/script-tests PerformanceTests/SunSpider/profiler-test.yaml LayoutTests/jsc-layout-tests.yaml
Warning: did not find json or highline; some features will be disabled.
Error: #<LoadError: no such file to load -- json>

This in spite of the json and highline gems both already installed.  The issue is that for earlier versions of ruby (probably before 1.9), we need to explicitly require "rubygems".  Adding this to the relevant scripts fixes the issue.

[Mark Lam]

Created attachment 213712 [details]
the patch.

[Mark Hahnenberg]

Comment on attachment 213712 [details]
the patch.

r=me. Did you test how this affects newer versions of ruby?

[Mark Lam]

(In reply to comment #2)
> (From update of attachment 213712 [details])
> r=me. Did you test how this affects newer versions of ruby?

Thanks for the review.  Yes, I tested it.  Works fine on newer versions of ruby.

[Mark Lam]

Landed in r157131: <http://trac.webkit.org/r157131>.