Bug 122495 – [Mac] WebNetscapePluginView should no longer use deleteAllValues

• Component: Plug-ins
• Status: RESOLVED FIXED

[Darin Adler]

WebNetscapePluginView should no longer use deleteAllValues

[Darin Adler]

Created attachment 213666 [details]
Patch

[Andreas Kling]

Comment on attachment 213666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213666&action=review

Too tired to parse this code but here's a comment:

> Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:710
> +    for (auto it = timers->begin(), end = timers->end(); it != end; ++it)

You can use range-based for in WebKit/mac.

> Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:725
> +    for (auto it = timers->begin(), end = timers->end(); it != end; ++it) {

Same here.

[Darin Adler]

Created attachment 213673 [details]
Patch

[Anders Carlsson]

Comment on attachment 213673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213673&action=review

> Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:711
> +    for (auto& it: *timers)
> +        it.value->stop();

Can use timers->values() here to avoid it.value.

> Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:725
> +    for (auto& it: *timers) {

Same thing here.

> Source/WebKit/mac/Plugins/WebNetscapePluginView.mm:2165
> +    while (timerID == 0 || HashTraits<uint32>::isDeletedValue(timerID) || *(slot = &timers->add(timerID, nullptr).iterator->value));

I think we have HashSet::isGoodValue that you can use here.

[Darin Adler]

Committed r157109: <http://trac.webkit.org/changeset/157109>