Summary: | A test that hangs at cleanup stage confuses webkitpy hugely | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dpranke, simon.fraser, thorton | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=160782 | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2013-10-07 17:29:08 PDT
This is probably essentially the same as bug 118602. It's not clear that there's a good way to fix this given the current way the test harness communicates w/ WTR. Created attachment 232579 [details]
freeze (dont open!)
Updated steps to reproduce:
1. Download attached freeze.html into LayoutTests.
2. run-webkit-tests -2 freeze.html fast/encoding/ahram-org-eg.html --debug-rwt-logging --child-processes=1
Created attachment 235034 [details]
proposed fix
Comment on attachment 235034 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=235034&action=review > Tools/WebKitTestRunner/TestInvocation.cpp:206 > + // The process froze while loading about:blank, let's start a fresh one. > + // It would be nice to report that the previous test froze after dumping results, but we have no way to do that. Can we log here? No, the script doesn't expect any output before the next test begins. Comment on attachment 235034 [details] proposed fix Clearing flags on attachment: 235034 Committed r171167: <http://trac.webkit.org/changeset/171167> All reviewed patches have been landed. Closing bug. |