Bug 122475

Summary: A test that hangs at cleanup stage confuses webkitpy hugely
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dpranke, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=160782
Attachments:
Description Flags
freeze (dont open!)
none
proposed fix none

Alexey Proskuryakov
Reported 2013-10-07 17:29:08 PDT
fast/forms/form-associated-element-crash3.html is a test that's known to hang after it dumps results (see bug 122130). Having a test like this confuses WebKitTestRunner a lot. 1. There is output saying that last line of output was not a newline, and there is a bug. 2. The next test is incorrectly reported as crashing. $ run-webkit-tests -2 --no-retry-failures -v fast/forms --child-processes=1 ... [150/810] fast/forms/form-associated-element-crash3.html passed Last character read from DRT stdout line was not a newline! This indicates either a NRWT or DRT bug. [151/810] fast/forms/form-associated-element-removal.html failed (WebProcess crashed [pid=44775])
Attachments
freeze (dont open!) (68 bytes, text/html)
2014-06-05 13:33 PDT, Alexey Proskuryakov 		no flags
Details
proposed fix (4.70 KB, patch)
2014-07-16 16:26 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2013-10-07 18:23:13 PDT
This is probably essentially the same as bug 118602. It's not clear that there's a good way to fix this given the current way the test harness communicates w/ WTR.
Alexey Proskuryakov
Comment 2 2014-06-05 13:33:21 PDT
Created attachment 232579 [details] freeze (dont open!) Updated steps to reproduce: 1. Download attached freeze.html into LayoutTests. 2. run-webkit-tests -2 freeze.html fast/encoding/ahram-org-eg.html --debug-rwt-logging --child-processes=1
Alexey Proskuryakov
Comment 3 2014-06-05 13:52:11 PDT
<rdar://problem/17184354>
Alexey Proskuryakov
Comment 4 2014-07-16 16:26:55 PDT
Created attachment 235034 [details] proposed fix
Simon Fraser (smfr)
Comment 5 2014-07-16 16:49:32 PDT
Comment on attachment 235034 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=235034&action=review > Tools/WebKitTestRunner/TestInvocation.cpp:206 > + // The process froze while loading about:blank, let's start a fresh one. > + // It would be nice to report that the previous test froze after dumping results, but we have no way to do that. Can we log here?
Alexey Proskuryakov
Comment 6 2014-07-16 16:54:49 PDT
No, the script doesn't expect any output before the next test begins.
WebKit Commit Bot
Comment 7 2014-07-16 19:27:02 PDT
Comment on attachment 235034 [details] proposed fix Clearing flags on attachment: 235034 Committed r171167: <http://trac.webkit.org/changeset/171167>
WebKit Commit Bot
Comment 8 2014-07-16 19:27:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.