Bug 122466

Summary: [Win] Add checks for proper build/test setup
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch darin: review+

Brent Fulgham
Reported 2013-10-07 14:05:39 PDT
Maintaining Windows build and test bots seems to be more difficult than it should be. I'd like to add some checks to build-webkit and run-webkit-tests that would make sure a few things are set up properly: 1. Make sure that Windows knows not to leave an "OK/Cancel" dialog displayed for user input that will never come on our test runners when something bad happens. 2. Make sure we have consistent settings between the 32-bit and 64-bit Windows environments so that we can support tests on both platforms. 3. Confirm that svn and python versions are "known good" versions. Python 2.7.3 under Cygwin has problems, for example. We might want to add other checks in the future.
Attachments
Patch (9.59 KB, patch)
2013-10-07 18:19 PDT, Brent Fulgham 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-10-07 18:19:33 PDT
Created attachment 213635 [details] Patch
Brent Fulgham
Comment 2 2013-10-08 08:50:06 PDT
Committed r157107: <http://trac.webkit.org/changeset/157107>
Note You need to log in before you can comment on or make changes to this bug.