Bug 122465

Summary: Always force discrete mode when running layout tests
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Anders Carlsson
Reported 2013-10-07 13:05:22 PDT
Always force discrete mode when running layout tests
Attachments
Patch (10.11 KB, patch)
2013-10-07 13:10 PDT, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-10-07 13:10:56 PDT
Created attachment 213615 [details] Patch
Tim Horton
Comment 2 2013-10-07 13:20:46 PDT
Comment on attachment 213615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213615&action=review > Tools/DumpRenderTree/mac/LayoutTestHelper.m:173 > + while ((option = getopt_long(argc, (char * const *)argv, "", options, NULL)) != -1) { not sure those stars are right > Tools/DumpRenderTree/mac/LayoutTestHelper.m:175 > + case '?': // unknown or ambiguous option case shouldn’t be indented
Anders Carlsson
Comment 3 2013-10-07 13:26:58 PDT
Committed r157057: <http://trac.webkit.org/changeset/157057>
Darin Adler
Comment 4 2013-10-07 16:00:00 PDT
This is causing lots of failures on the test bots. 71 tests are failing on most Mac bots (Lion, Mountain Lion, Release, Debug, WebKit1, WebKit2).
Darin Adler
Comment 5 2013-10-07 16:01:38 PDT
And I guess you knew that because http://trac.webkit.org/changeset/157063 is an attempt to fix it.
Note You need to log in before you can comment on or make changes to this bug.