Bug 122443

Summary: Conditional support in bindings code generator for overloaded functions
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, pnormand, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79203, 122301    
Attachments:
Description Flags
patch
none
Patch none

Philippe Normand
Reported 2013-10-07 03:17:53 PDT
Use-case: the DOMURL interface has overloaded functions in URLMediaSource.idl and URLMediaStream.idl but the code for these needs to be generated only when MEDIA_SOURCE and MEDIA_STREAM are respectively enabled. This is just a matter of generating #if ENABLE(Conditional) for the overloaded functions.
Attachments
patch (4.23 KB, patch)
2013-10-07 03:42 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2013-10-07 09:24 PDT, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2013-10-07 03:42:43 PDT
Created attachment 213575 [details] patch
Philippe Normand
Comment 2 2013-10-07 03:44:25 PDT
perhaps Christophe can have a look at this one? :)
Jer Noble
Comment 3 2013-10-07 08:16:45 PDT
We should add a bindings test for this case. I'm more than willing to do the URLMediaSource and URLMediaStream work in bug 122301, which will simplify this patch.
Philippe Normand
Comment 4 2013-10-07 08:25:16 PDT
(In reply to comment #3) > We should add a bindings test for this case. I'm more than willing to do the URLMediaSource and URLMediaStream work in bug 122301, which will simplify this patch. Ok, I'll write a test and let you handle bug 122301 then!
Philippe Normand
Comment 5 2013-10-07 08:25:49 PDT
Comment on attachment 213575 [details] patch I'll add a test and remove the URL* changes.
Philippe Normand
Comment 6 2013-10-07 08:54:24 PDT
Oh actually the patch is covered by tests already, I'll rebaseline the results.
Philippe Normand
Comment 7 2013-10-07 09:24:41 PDT
Created attachment 213597 [details] Patch
WebKit Commit Bot
Comment 8 2013-10-07 10:44:16 PDT
Comment on attachment 213597 [details] Patch Clearing flags on attachment: 213597 Committed r157048: <http://trac.webkit.org/changeset/157048>
WebKit Commit Bot
Comment 9 2013-10-07 10:44:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.