Bug 122443

Summary: Conditional support in bindings code generator for overloaded functions
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, pnormand, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79203, 122301    
Attachments:
Description Flags
patch
none
Patch none

Description Philippe Normand 2013-10-07 03:17:53 PDT 
Use-case: the DOMURL interface has overloaded functions in URLMediaSource.idl and URLMediaStream.idl but the code for these needs to be generated only when MEDIA_SOURCE and MEDIA_STREAM are respectively enabled.

This is just a matter of generating #if ENABLE(Conditional) for the overloaded functions.
Comment 1 Philippe Normand 2013-10-07 03:42:43 PDT 
Created attachment 213575 [details]
patch
Comment 2 Philippe Normand 2013-10-07 03:44:25 PDT 
perhaps Christophe can have a look at this one? :)
Comment 3 Jer Noble 2013-10-07 08:16:45 PDT 
We should add a bindings test for this case.  I'm more than willing to do the URLMediaSource and URLMediaStream work in bug 122301, which will simplify this patch.
Comment 4 Philippe Normand 2013-10-07 08:25:16 PDT 
(In reply to comment #3)
> We should add a bindings test for this case.  I'm more than willing to do the URLMediaSource and URLMediaStream work in bug 122301, which will simplify this patch.

Ok, I'll write a test and let you handle bug 122301 then!
Comment 5 Philippe Normand 2013-10-07 08:25:49 PDT 
Comment on attachment 213575 [details]
patch

I'll add a test and remove the URL* changes.
Comment 6 Philippe Normand 2013-10-07 08:54:24 PDT 
Oh actually the patch is covered by tests already, I'll rebaseline the results.
Comment 7 Philippe Normand 2013-10-07 09:24:41 PDT 
Created attachment 213597 [details]
Patch
Comment 8 WebKit Commit Bot 2013-10-07 10:44:16 PDT 
Comment on attachment 213597 [details]
Patch

Clearing flags on attachment: 213597

Committed r157048: <http://trac.webkit.org/changeset/157048>
Comment 9 WebKit Commit Bot 2013-10-07 10:44:18 PDT 
All reviewed patches have been landed.  Closing bug.