Bug 122438

Summary:

rangeOfContents() should take a Node&.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

DOM

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+, buildbot: commit-queue-

Description Andreas Kling 2013-10-06 20:51:33 PDT

This function is never called with a null Node*.

Comment 1 Andreas Kling 2013-10-06 20:51:56 PDT

Created attachment 213560 [details]
Patch

Comment 2 Build Bot 2013-10-06 22:38:29 PDT

Comment on attachment 213560 [details]
Patch

Attachment 213560 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3560029

Comment 3 Darin Adler 2013-10-07 10:36:23 PDT

Comment on attachment 213560 [details]
Patch

r=me, but fix Windows

     1>..\..\win\WebFrame.cpp(1935): error C2664: 'WebCore::rangeOfContents' : cannot convert parameter 1 from 'WebCore::Document *' to 'WebCore::Node &'

Comment 4 Andreas Kling 2013-10-10 03:47:59 PDT

Committed r157212: <http://trac.webkit.org/changeset/157212>