Bug 122427

Summary: CTTE: Use references in and around DragController
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gtk-ews, gyuyoung.kim, philn, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Sam Weinig 2013-10-06 15:03:00 PDT 
CTTE: Use references in and around DragController
Comment 1 Sam Weinig 2013-10-06 15:04:41 PDT 
Created attachment 213529 [details]
Patch
Comment 2 Sam Weinig 2013-10-06 15:05:14 PDT 
This touches a lot of port code. Let's give the bots a moment to chew on it.
Comment 3 WebKit Commit Bot 2013-10-06 15:07:16 PDT 
Attachment 213529 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/objc/DOMHTML.mm', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/editing/markup.h', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FileInputType.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h', u'Source/WebCore/loader/EmptyClients.h', u'Source/WebCore/page/DragClient.h', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/DragController.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/efl/DragControllerEfl.cpp', u'Source/WebCore/page/gtk/DragControllerGtk.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/win/DragControllerWin.cpp', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/Pasteboard.h', u'Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp', u'Source/WebCore/platform/gtk/GtkDragAndDropHelper.h', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/mac/DragDataMac.mm', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DragClientEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/DragClientEfl.h', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/DragClientGtk.h', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.h', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebDragClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebDragClient.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebDragClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebDragClient.h', u'Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebCore/page/gtk/DragControllerGtk.cpp:56:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/page/DragClient.h:51:  The parameter name "dragImage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/DragClientGtk.h:54:  The parameter name "dragImage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 3 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 EFL EWS Bot 2013-10-06 15:23:07 PDT 
Comment on attachment 213529 [details]
Patch

Attachment 213529 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/3486068
Comment 5 EFL EWS Bot 2013-10-06 15:28:24 PDT 
Comment on attachment 213529 [details]
Patch

Attachment 213529 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/3558062
Comment 6 kov's GTK+ EWS bot 2013-10-06 15:48:30 PDT 
Comment on attachment 213529 [details]
Patch

Attachment 213529 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/3558066
Comment 7 Build Bot 2013-10-06 17:40:45 PDT 
Comment on attachment 213529 [details]
Patch

Attachment 213529 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3518047
Comment 8 Sam Weinig 2013-10-06 23:55:12 PDT 
Created attachment 213567 [details]
Patch
Comment 9 WebKit Commit Bot 2013-10-06 23:57:01 PDT 
Attachment 213567 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/objc/DOMHTML.mm', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/editing/markup.h', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FileInputType.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h', u'Source/WebCore/loader/EmptyClients.h', u'Source/WebCore/page/DragClient.h', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/DragController.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/efl/DragControllerEfl.cpp', u'Source/WebCore/page/gtk/DragControllerGtk.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/win/DragControllerWin.cpp', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/Pasteboard.h', u'Source/WebCore/platform/efl/DragDataEfl.cpp', u'Source/WebCore/platform/gtk/DragDataGtk.cpp', u'Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp', u'Source/WebCore/platform/gtk/GtkDragAndDropHelper.h', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/mac/DragDataMac.mm', u'Source/WebCore/platform/win/DragDataWin.cpp', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DragClientEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/DragClientEfl.h', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/DragClientGtk.h', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.h', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebDragClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebDragClient.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebDragClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebDragClient.h', u'Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebCore/platform/win/PasteboardWin.cpp:811:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/page/gtk/DragControllerGtk.cpp:56:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/page/DragClient.h:51:  The parameter name "dragImage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/DragClientGtk.h:54:  The parameter name "dragImage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Build Bot 2013-10-07 00:34:37 PDT 
Comment on attachment 213567 [details]
Patch

Attachment 213567 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3512091
Comment 11 kov's GTK+ EWS bot 2013-10-07 00:38:24 PDT 
Comment on attachment 213567 [details]
Patch

Attachment 213567 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/3515127
Comment 12 Sam Weinig 2013-10-07 10:21:56 PDT 
Created attachment 213601 [details]
Patch
Comment 13 WebKit Commit Bot 2013-10-07 10:24:20 PDT 
Attachment 213601 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/objc/DOMHTML.mm', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/editing/markup.h', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FileInputType.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h', u'Source/WebCore/loader/EmptyClients.h', u'Source/WebCore/page/DragClient.h', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/DragController.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/efl/DragControllerEfl.cpp', u'Source/WebCore/page/gtk/DragControllerGtk.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/page/win/DragControllerWin.cpp', u'Source/WebCore/platform/DragData.h', u'Source/WebCore/platform/Pasteboard.h', u'Source/WebCore/platform/efl/DragDataEfl.cpp', u'Source/WebCore/platform/gtk/DragDataGtk.cpp', u'Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp', u'Source/WebCore/platform/gtk/GtkDragAndDropHelper.h', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/mac/DragDataMac.mm', u'Source/WebCore/platform/win/DragDataWin.cpp', u'Source/WebCore/platform/win/PasteboardWin.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DragClientEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/DragClientEfl.h', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/DragClientGtk.h', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.h', u'Source/WebKit/mac/WebCoreSupport/WebDragClient.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebDragClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebDragClient.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebDragClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebDragClient.h', u'Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebCore/platform/win/PasteboardWin.cpp:811:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/page/gtk/DragControllerGtk.cpp:56:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/page/DragClient.h:51:  The parameter name "dragImage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/gtk/WebCoreSupport/DragClientGtk.h:54:  The parameter name "dragImage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Build Bot 2013-10-07 11:04:00 PDT 
Comment on attachment 213601 [details]
Patch

Attachment 213601 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3707005
Comment 15 Sam Weinig 2013-10-07 11:08:37 PDT 
Created attachment 213604 [details]
Patch
Comment 16 Build Bot 2013-10-07 11:50:56 PDT 
Comment on attachment 213604 [details]
Patch

Attachment 213604 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/3720001
Comment 17 Sam Weinig 2013-10-07 12:22:33 PDT 
Created attachment 213611 [details]
Patch
Comment 18 WebKit Commit Bot 2013-10-07 13:34:24 PDT 
Comment on attachment 213611 [details]
Patch

Clearing flags on attachment: 213611

Committed r157058: <http://trac.webkit.org/changeset/157058>
Comment 19 WebKit Commit Bot 2013-10-07 13:34:27 PDT 
All reviewed patches have been landed.  Closing bug.