Bug 122407

Summary: [GTK] Missing introspection information for WebExtensions
Product: WebKit Reporter: Marcel Tiede <marcel.tiede>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, pnormand, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch pnormand: review+

Description Marcel Tiede 2013-10-06 04:12:42 PDT 
While trying to create a WebExtension in vala i recognized that the classes for WebExtensions (WebKitWebExtension, WebKitWebPage, WebKitFrame, WebKitScriptWorld) are not available in the corresponding gir file. Is this intentional or are they just missing?
Comment 1 Carlos Garcia Campos 2013-10-06 23:49:29 PDT 
I've also noticed that we are generating the GObject DOM bindings introspection in the same gir than the UI process API. I think we should add a new gir for Web Extensions API that also includes the DOM bindings.
Comment 2 Carlos Garcia Campos 2013-12-25 01:30:23 PST 
Created attachment 219986 [details]
Patch
Comment 3 Carlos Garcia Campos 2013-12-25 01:49:42 PST 
Committed r161063: <http://trac.webkit.org/changeset/161063>
Comment 4 Philippe Normand 2013-12-25 06:06:32 PST 
Hum this one broke the build. I'm going to try to fix it
Comment 5 Philippe Normand 2013-12-25 06:50:24 PST 
https://trac.webkit.org/r161065
Comment 6 Carlos Garcia Campos 2013-12-26 00:57:39 PST 
(In reply to comment #4)
> Hum this one broke the build. I'm going to try to fix it

I'm sorry, I even made a clean build to make sure it worked and it built for me
Comment 7 Carlos Garcia Campos 2013-12-26 00:58:05 PST 
(In reply to comment #5)
> https://trac.webkit.org/r161065

So, I guess it didn't fail here because I have webkit installed.
Comment 8 Carlos Garcia Campos 2013-12-26 00:58:33 PST 
(In reply to comment #7)
> (In reply to comment #5)
> > https://trac.webkit.org/r161065
> 
> So, I guess it didn't fail here because I have webkit installed.

And thanks a lot for fixing it :-)
Comment 9 Philippe Normand 2013-12-26 01:11:14 PST 
(In reply to comment #7)
> (In reply to comment #5)
> > https://trac.webkit.org/r161065
> 
> So, I guess it didn't fail here because I have webkit installed.

Exactly :)