Bug 122407

Summary: [GTK] Missing introspection information for WebExtensions
Product: WebKit Reporter: Marcel Tiede <marcel.tiede>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, pnormand, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch pnormand: review+

Marcel Tiede
Reported 2013-10-06 04:12:42 PDT
While trying to create a WebExtension in vala i recognized that the classes for WebExtensions (WebKitWebExtension, WebKitWebPage, WebKitFrame, WebKitScriptWorld) are not available in the corresponding gir file. Is this intentional or are they just missing?
Attachments
Patch (4.03 KB, patch)
2013-12-25 01:30 PST, Carlos Garcia Campos 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-10-06 23:49:29 PDT
I've also noticed that we are generating the GObject DOM bindings introspection in the same gir than the UI process API. I think we should add a new gir for Web Extensions API that also includes the DOM bindings.
Carlos Garcia Campos
Comment 2 2013-12-25 01:30:23 PST
Created attachment 219986 [details] Patch
Carlos Garcia Campos
Comment 3 2013-12-25 01:49:42 PST
Committed r161063: <http://trac.webkit.org/changeset/161063>
Philippe Normand
Comment 4 2013-12-25 06:06:32 PST
Hum this one broke the build. I'm going to try to fix it
Philippe Normand
Comment 5 2013-12-25 06:50:24 PST
https://trac.webkit.org/r161065
Carlos Garcia Campos
Comment 6 2013-12-26 00:57:39 PST
(In reply to comment #4) > Hum this one broke the build. I'm going to try to fix it I'm sorry, I even made a clean build to make sure it worked and it built for me
Carlos Garcia Campos
Comment 7 2013-12-26 00:58:05 PST
(In reply to comment #5) > https://trac.webkit.org/r161065 So, I guess it didn't fail here because I have webkit installed.
Carlos Garcia Campos
Comment 8 2013-12-26 00:58:33 PST
(In reply to comment #7) > (In reply to comment #5) > > https://trac.webkit.org/r161065 > > So, I guess it didn't fail here because I have webkit installed. And thanks a lot for fixing it :-)
Philippe Normand
Comment 9 2013-12-26 01:11:14 PST
(In reply to comment #7) > (In reply to comment #5) > > https://trac.webkit.org/r161065 > > So, I guess it didn't fail here because I have webkit installed. Exactly :)
Note You need to log in before you can comment on or make changes to this bug.