Pass VM instead of ExecState to StringObject constructor.

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Andreas Kling]

Pass VM instead of ExecState to StringObject constructor.

[Andreas Kling]

Created attachment 213475 [details]
Patch

[Sam Weinig]

Comment on attachment 213475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213475&action=review

> Source/JavaScriptCore/runtime/StringConstructor.cpp:98
>      if (!exec->argumentCount())
> -        return JSValue::encode(StringObject::create(exec, globalObject->stringObjectStructure()));
> +        return JSValue::encode(StringObject::create(exec->vm(), globalObject->stringObjectStructure()));
>      
> -    return JSValue::encode(StringObject::create(exec, globalObject->stringObjectStructure(), exec->uncheckedArgument(0).toString(exec)));
> +    return JSValue::encode(StringObject::create(exec->vm(), globalObject->stringObjectStructure(), exec->uncheckedArgument(0).toString(exec)));

You are doing exec->vm() twice.  Can you pull it out into a local?

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:1599
> +            StringObject* obj = constructString(m_exec->vm(), m_globalObject, jsEmptyString(&m_exec->vm()));

You are doing m_exec->vm() twice here.  Can you pull it out into a local?

[Andreas Kling]

Committed r156998: <http://trac.webkit.org/changeset/156998>