Bug 122378

Summary: Heap/WeakSet/JSScope should store/return VM as reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED WONTFIX    
Severity: Normal CC: buildbot, commit-queue, eflews.bot, gyuyoung.kim, kling, rego+ews, rniwa, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Lander
buildbot: commit-queue-
Lander buildbot: commit-queue-

Andreas Kling
Reported 2013-10-05 00:43:34 PDT
Heap/WeakSet/JSScope should store/return VM as reference.
Attachments
Patch (27.37 KB, patch)
2013-10-05 00:44 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Lander (27.67 KB, patch)
2013-10-05 04:11 PDT, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Lander (27.83 KB, patch)
2013-10-05 14:17 PDT, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-05 00:44:00 PDT
Created attachment 213446 [details] Patch
EFL EWS Bot
Comment 2 2013-10-05 00:51:12 PDT
Comment on attachment 213446 [details] Patch Attachment 213446 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3360020
EFL EWS Bot
Comment 3 2013-10-05 00:52:12 PDT
Comment on attachment 213446 [details] Patch Attachment 213446 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3361025
Build Bot
Comment 4 2013-10-05 01:14:59 PDT
Comment on attachment 213446 [details] Patch Attachment 213446 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3362019
Build Bot
Comment 5 2013-10-05 01:27:56 PDT
Comment on attachment 213446 [details] Patch Attachment 213446 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3352022
Andreas Kling
Comment 6 2013-10-05 04:11:16 PDT
Created attachment 213449 [details] Lander
Build Bot
Comment 7 2013-10-05 04:56:24 PDT
Comment on attachment 213449 [details] Lander Attachment 213449 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3321109
Build Bot
Comment 8 2013-10-05 05:40:23 PDT
Comment on attachment 213449 [details] Lander Attachment 213449 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3313133
Andreas Kling
Comment 9 2013-10-05 14:17:03 PDT
Created attachment 213470 [details] Lander
Build Bot
Comment 10 2013-10-05 14:45:41 PDT
Comment on attachment 213470 [details] Lander Attachment 213470 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3287020
Build Bot
Comment 11 2013-10-05 15:02:54 PDT
Comment on attachment 213470 [details] Lander Attachment 213470 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3444002
Csaba Osztrogonác
Comment 12 2014-02-13 04:06:16 PST
Comment on attachment 213446 [details] Patch Cleared Darin Adler's review+ from obsolete attachment 213446 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Andreas Kling
Comment 13 2014-12-07 16:01:49 PST
This didn't work out because we can't compute the offset of a Foo& member for LLInt.
Note You need to log in before you can comment on or make changes to this bug.