Bug 122359
| Summary: | Internals.idl use of [] seems wrong | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Minor | CC: | ahmad.saleem792, cdumez, haraken, zan |
| Priority: | P4 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Alexey Proskuryakov
DOMString[] getReferencedFilePaths();
...
[RaisesException] DOMString[] formControlStateOfPreviousHistoryItem();
...
DOMString[] shortcutIconURLs(Document document);
DOMString[] allIconURLs(Document document);
These don't look like they are returning a reference. Shouldn't they all return sequences instead?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
https://searchfox.org/wubkat/source/Source/WebCore/testing/Internals.cpp#3840
Vector<String> Internals::getReferencedFilePaths() const
{
frame()->loader().history().saveDocumentAndScrollState();
return FormController::referencedFilePaths(frame()->loader().history().currentItem()->documentState());
}
^ Only able to find this reference about this. Is it still applicable?