Bug 122357

Summary: Teach webkitdirs.pm to honor the --64-bit flag
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates, ddkilzer, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ddkilzer: review+

Brent Fulgham
Reported 2013-10-04 16:02:44 PDT
The webkitdirs.pm module always inserts the "--32-bit" build flag into the list of arguments. This prevents a 64-bit build on Windows, even when you explicitly pass the "--64-bit" flag. This patch modifies the WebKit Perl modules to not override the user's explicit build target input.
Attachments
Patch (2.65 KB, patch)
2013-10-04 16:10 PDT, Brent Fulgham 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-10-04 16:10:53 PDT
Created attachment 213414 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2013-10-04 16:29:37 PDT
Comment on attachment 213414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213414&action=review r=me > Tools/Scripts/webkitdirs.pm:886 > + return $#matchingIndices > -1; I think this might be clearer: return scalar @matchingIndices > 0; Or: return scalar @matchingIndices;
Brent Fulgham
Comment 3 2013-10-04 16:33:19 PDT
Committed r156926: <http://trac.webkit.org/changeset/156926>
Brent Fulgham
Comment 4 2013-10-04 16:57:41 PDT
Please be sure to also include the small follow-up change: Committed r156928: <http://trac.webkit.org/changeset/r156928 >
Radar WebKit Bug Importer
Comment 5 2013-10-04 16:57:57 PDT
<rdar://problem/15157760>
Note You need to log in before you can comment on or make changes to this bug.