Bug 122342

Summary: Tighten typing in some RenderLayer code.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2013-10-04 12:41:59 PDT 
Let's tighten some of the Node and RenderObject usage in here.
Comment 1 Andreas Kling 2013-10-04 12:48:39 PDT 
Created attachment 213390 [details]
Patch
Comment 2 Antti Koivisto 2013-10-04 12:51:24 PDT 
Comment on attachment 213390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213390&action=review

> Source/WebCore/rendering/RenderTableRow.h:126
> +inline RenderTableRow& toRenderTableRow(RenderObject& object)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(object.isTableRow());
> +    return static_cast<RenderTableRow&>(object);
> +}

Could add const version too since you are here.
Comment 3 Antti Koivisto 2013-10-04 12:55:31 PDT 
Comment on attachment 213390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213390&action=review

> Source/WebCore/rendering/RenderLayer.cpp:5376
> +            LayoutRect bbox = cell->borderBoxRect();

Uh bbox
Comment 4 WebKit Commit Bot 2013-10-04 15:20:36 PDT 
Comment on attachment 213390 [details]
Patch

Clearing flags on attachment: 213390

Committed r156915: <http://trac.webkit.org/changeset/156915>
Comment 5 WebKit Commit Bot 2013-10-04 15:20:38 PDT 
All reviewed patches have been landed.  Closing bug.