Bug 122339

Summary: Support for-of syntax
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+, eflews.bot: commit-queue-

Oliver Hunt
Reported 2013-10-04 12:29:59 PDT
Support for-of syntax
Attachments
Patch (41.86 KB, patch)
2013-10-04 12:36 PDT, Oliver Hunt 		ggaren: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-10-04 12:36:36 PDT
Created attachment 213388 [details] Patch
EFL EWS Bot
Comment 2 2013-10-04 13:03:40 PDT
Comment on attachment 213388 [details] Patch Attachment 213388 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3286006
Geoffrey Garen
Comment 3 2013-10-04 13:10:20 PDT
Comment on attachment 213388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213388&action=review r=me Please add a few tests we talked about. > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1791 > + bool optimizedForinAccess = false; Please remove this. > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1826 > + if (optimizedForinAccess) > + generator.popOptimisedForIn(); Please remove this. It's dead in the for-of case. > Source/JavaScriptCore/runtime/ArrayIteratorPrototype.cpp:81 > - > + Please revert this accidental whitespace change.
Oliver Hunt
Comment 4 2013-10-04 13:34:00 PDT
Committed r156910: <http://trac.webkit.org/changeset/156910>
Note You need to log in before you can comment on or make changes to this bug.