Bug 122310

Summary: REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: New BugsAssignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, mitz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Rowe (bdash)
Reported 2013-10-03 19:31:14 PDT
REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build
Attachments
Patch (2.77 KB, patch)
2013-10-03 19:31 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2013-10-03 19:31:22 PDT
Created attachment 213324 [details] Patch
WebKit Commit Bot
Comment 2 2013-10-03 19:33:25 PDT
Attachment 213324 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj']" exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2013-10-03 19:49:20 PDT
I suspect that the post processing of WKBase.h in WebKit2 results in a similar issue.
WebKit Commit Bot
Comment 4 2013-10-03 20:18:21 PDT
Comment on attachment 213324 [details] Patch Clearing flags on attachment: 213324 Committed r156873: <http://trac.webkit.org/changeset/156873>
WebKit Commit Bot
Comment 5 2013-10-03 20:18:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.