Bug 122295

Summary:

Web Inspector: Remove the old front-end from WebKit

Product:

WebKit

Reporter:

Marcelo Morais <m.morais>

Component:

Web Inspector

Assignee:

Marcelo Morais <m.morais>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

afonso.costa, andre.vl, buildbot, cdumez, commit-queue, graouts, gyuyoung.kim, joepeck, jrogers, rakuco, rniwa, syoichi, timothy, tonikitoo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

118676

Bug Blocks:

Attachments:

Description	Flags
Patch - Part 1/3	none
Patch - Part 2/3	timothy: review+, buildbot: commit-queue-
Patch - Part 3/3	timothy: review+
Patch to update project files	none

Marcelo Morais

Reported 2013-10-03 12:40:53 PDT

Now that efl/gtk/mac/win use the new inspector, the code of the old inspector is no longer needed.

Attachments
Patch - Part 1/3 (57.26 KB, patch) 2013-10-10 11:23 PDT, Marcelo Morais	no flags	Details Formatted Diff Diff
Patch - Part 2/3 (1.40 MB, patch) 2013-10-10 11:25 PDT, Marcelo Morais	timothy: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Patch - Part 3/3 (4.17 MB, patch) 2013-10-10 11:26 PDT, Marcelo Morais	timothy: review+	Details Formatted Diff Diff
Patch to update project files (78.66 KB, patch) 2013-10-10 14:31 PDT, Marcelo Morais	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-10-03 12:41:29 PDT

<rdar://problem/15144447>

Marcelo Morais

Comment 2 2013-10-08 13:55:49 PDT

Hello, I am removing the old front-end and I am also checking where we have references to it. In Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters and Source/WebCore/WebCore.vcxproj/WebCore.vcxproj we still have the reference to files from the old inspector, can I remove them?

Marcelo Morais

Comment 3 2013-10-08 14:04:32 PDT

In Source/WebCore/WebCore.xcodeproj/project.pbxproj we have references to files from the old front-end too, can I remove them?

Timothy Hatcher

Comment 4 2013-10-08 14:47:46 PDT

(In reply to comment #3) > In Source/WebCore/WebCore.xcodeproj/project.pbxproj we have references to files from the old front-end too, can I remove them? Yes, those should be removed too.

Marcelo Morais

Comment 5 2013-10-10 11:23:29 PDT

Created attachment 213904 [details] Patch - Part 1/3 This first patch is just to skip old inspector UI tests for all platforms

Marcelo Morais

Comment 6 2013-10-10 11:25:00 PDT

Created attachment 213905 [details] Patch - Part 2/3 First part of the remotion

Marcelo Morais

Comment 7 2013-10-10 11:26:25 PDT

Created attachment 213906 [details] Patch - Part 3/3 Second part of the remotion

Timothy Hatcher

Comment 8 2013-10-10 11:48:46 PDT

Comment on attachment 213905 [details] Patch - Part 2/3 View in context: https://bugs.webkit.org/attachment.cgi?id=213905&action=review > Source/WebCore/ChangeLog:8 > + Due to patch size limits, the remotion of the front-end will be done in two parts. remotion?

Build Bot

Comment 9 2013-10-10 11:53:07 PDT

Comment on attachment 213905 [details] Patch - Part 2/3 Attachment 213905 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3876051

Timothy Hatcher

Comment 10 2013-10-10 11:54:15 PDT

Please land part 2 and 3 as one commit. Part 1 is fine to land separately and first.

Timothy Hatcher

Comment 11 2013-10-10 11:57:06 PDT

Looks like the build failure is expected since the patch was split into two parts.

Marcelo Morais

Comment 12 2013-10-10 12:05:21 PDT

(In reply to comment #11) > Looks like the build failure is expected since the patch was split into two parts. Hi Timothy, thanks for the review :) I've tried, but as one patch, exceeds the patch's size limit. What can I do to solve this?

Build Bot

Comment 13 2013-10-10 12:10:41 PDT

Comment on attachment 213905 [details] Patch - Part 2/3 Attachment 213905 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3876056

Timothy Hatcher

Comment 14 2013-10-10 12:23:47 PDT

Someone with commit access will need to do it. I can do it for you.

Marcelo Morais

Comment 15 2013-10-10 12:35:12 PDT

(In reply to comment #14) > Someone with commit access will need to do it. I can do it for you. Thank you Timothy! :)

WebKit Commit Bot

Comment 16 2013-10-10 13:04:16 PDT

Comment on attachment 213904 [details] Patch - Part 1/3 Clearing flags on attachment: 213904 Committed r157246: <http://trac.webkit.org/changeset/157246>

Marcelo Morais

Comment 17 2013-10-10 14:31:02 PDT

Created attachment 213928 [details] Patch to update project files Timothy, after this just need to remove inspector/front-end.

WebKit Commit Bot

Comment 18 2013-10-10 17:04:14 PDT

Comment on attachment 213928 [details] Patch to update project files Clearing flags on attachment: 213928 Committed r157275: <http://trac.webkit.org/changeset/157275>

WebKit Commit Bot

Comment 19 2013-10-10 17:04:19 PDT

All reviewed patches have been landed. Closing bug.

Timothy Hatcher

Comment 20 2013-10-10 18:07:13 PDT

http://trac.webkit.org/changeset/157278

Note You need to log in before you can comment on or make changes to this bug.