| Summary: | Web Inspector: Remove the old front-end from WebKit | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Marcelo Morais <m.morais> | ||||||||||
| Component: | Web Inspector | Assignee: | Marcelo Morais <m.morais> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | afonso.costa, andre.vl, buildbot, cdumez, commit-queue, graouts, gyuyoung.kim, joepeck, jrogers, rakuco, rniwa, syoichi, timothy, tonikitoo, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | 118676 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Marcelo Morais
2013-10-03 12:40:53 PDT
Hello, I am removing the old front-end and I am also checking where we have references to it. In Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters and Source/WebCore/WebCore.vcxproj/WebCore.vcxproj we still have the reference to files from the old inspector, can I remove them? In Source/WebCore/WebCore.xcodeproj/project.pbxproj we have references to files from the old front-end too, can I remove them? (In reply to comment #3) > In Source/WebCore/WebCore.xcodeproj/project.pbxproj we have references to files from the old front-end too, can I remove them? Yes, those should be removed too. Created attachment 213904 [details]
Patch - Part 1/3
This first patch is just to skip old inspector UI tests for all platforms
Created attachment 213905 [details]
Patch - Part 2/3
First part of the remotion
Created attachment 213906 [details]
Patch - Part 3/3
Second part of the remotion
Comment on attachment 213905 [details] Patch - Part 2/3 View in context: https://bugs.webkit.org/attachment.cgi?id=213905&action=review > Source/WebCore/ChangeLog:8 > + Due to patch size limits, the remotion of the front-end will be done in two parts. remotion? Comment on attachment 213905 [details] Patch - Part 2/3 Attachment 213905 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3876051 Please land part 2 and 3 as one commit. Part 1 is fine to land separately and first. Looks like the build failure is expected since the patch was split into two parts. (In reply to comment #11) > Looks like the build failure is expected since the patch was split into two parts. Hi Timothy, thanks for the review :) I've tried, but as one patch, exceeds the patch's size limit. What can I do to solve this? Comment on attachment 213905 [details] Patch - Part 2/3 Attachment 213905 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3876056 Someone with commit access will need to do it. I can do it for you. (In reply to comment #14) > Someone with commit access will need to do it. I can do it for you. Thank you Timothy! :) Comment on attachment 213904 [details] Patch - Part 1/3 Clearing flags on attachment: 213904 Committed r157246: <http://trac.webkit.org/changeset/157246> Created attachment 213928 [details]
Patch to update project files
Timothy, after this just need to remove inspector/front-end.
Comment on attachment 213928 [details] Patch to update project files Clearing flags on attachment: 213928 Committed r157275: <http://trac.webkit.org/changeset/157275> All reviewed patches have been landed. Closing bug. |