Bug 122286 – Add a testcase for a bug that I had during the development. This code uses the asm.js style.

• Component: New Bugs
• Status: RESOLVED FIXED

[Nadav Rotem]

Add a testcase for a bug that I had during the development. This code uses the asm.js style.

[Nadav Rotem]

Created attachment 213279 [details]
Patch

[Nadav Rotem]

Adding a test case for a bug that I had during the development of the ValueToInt32 pattern. It looks like we don't have too many asm.js kind of programs.

[Nadav Rotem]

To be clear Emscripten is available under 2 licenses: MIT and University of Illinois/NCSA Open Source Licenses. The strlen function is a part of the emscript library that is a part of all auto-generated files.

[Filip Pizlo]

(In reply to comment #3)
> To be clear Emscripten is available under 2 licenses: MIT and University of Illinois/NCSA Open Source Licenses. The strlen function is a part of the emscript library that is a part of all auto-generated files.

I think we've already checked in emscripten code before so it should be fine!  Also we tend to be more lax for the licenses for tests in LayoutTests since those don't get "shipped" in products. We have everything from Apache license to LGPL and probably multiple varieties of the BSD-style licenses in the different tests.

[WebKit Commit Bot]

Comment on attachment 213279 [details]
Patch

Rejecting attachment 213279 [details] from commit-queue.

New failing tests:
js/regress/asmjs_bool_bug.html
Full output: http://webkit-queues.appspot.com/results/3152001

[WebKit Commit Bot]

Created attachment 213287 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 213279 [details]
Patch

Attachment 213279 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3144003

New failing tests:
js/regress/asmjs_bool_bug.html
svg/batik/filters/filterRegions.svg

[Build Bot]

Created attachment 213288 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 213279 [details]
Patch

Attachment 213279 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3151023

New failing tests:
js/regress/asmjs_bool_bug.html

[Build Bot]

Created attachment 213290 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 213279 [details]
Patch

Attachment 213279 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3148006

New failing tests:
js/regress/asmjs_bool_bug.html

[Build Bot]

Created attachment 213296 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Nadav Rotem]

Created attachment 213299 [details]
Patch

[Nadav Rotem]

I fixed the test name in the expected.txt file.

[WebKit Commit Bot]

Comment on attachment 213299 [details]
Patch

Clearing flags on attachment: 213299

Committed r156865: <http://trac.webkit.org/changeset/156865>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.