Bug 122276

Summary:

[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan, macpherson, menard, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

122213

Attachments:

Description	Flags
Patch	darin: review+

Zan Dobersek

Reported 2013-10-03 08:59:44 PDT

[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute

Attachments
Patch (21.78 KB, patch) 2013-10-03 09:01 PDT, Zan Dobersek	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2013-10-03 09:01:16 PDT

Created attachment 213259 [details] Patch

Darin Adler

Comment 2 2013-10-03 12:58:55 PDT

Comment on attachment 213259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213259&action=review > Source/WebCore/css/CSSCharsetRule.idl:23 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/CSSFontFaceLoadEvent.idl:36 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/CSSFontFaceRule.idl:25 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/CSSImportRule.idl:23 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/CSSPageRule.idl:23 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/CSSRule.idl:28 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/CSSStyleRule.idl:23 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/CSSUnknownRule.idl:24 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/CSSValue.idl:27 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/Counter.idl:23 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/RGBColor.idl:24 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/Rect.idl:22 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/StyleSheet.idl:28 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/WebKitCSSFilterRule.idl:32 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/WebKitCSSKeyframeRule.idl:31 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/WebKitCSSMixFunctionValue.idl:33 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/WebKitCSSRegionRule.idl:32 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change. > Source/WebCore/css/WebKitCSSViewportRule.idl:32 > + OperationsNotDeletable No operations in this interface, so it would be good not to make this change.

Zan Dobersek

Comment 3 2013-10-04 05:21:53 PDT

Committed r156886: <http://trac.webkit.org/changeset/156886>

Note You need to log in before you can comment on or make changes to this bug.