Bug 122206

Summary:

CTTE: DOMWrapperWorlds should be passed around by reference

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, japhet, jer.noble, jsbell, kangil.han, mkwst, rakuco, rniwa, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+, webkit-ews: commit-queue-

Sam Weinig

Reported 2013-10-01 23:18:54 PDT

CTTE: DOMWrapperWorlds should be passed around by reference

Attachments
Patch (124.12 KB, patch) 2013-10-01 23:21 PDT, Sam Weinig	kling: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2013-10-01 23:21:25 PDT

Created attachment 213154 [details] Patch

Early Warning System Bot

Comment 2 2013-10-01 23:33:01 PDT

Comment on attachment 213154 [details] Patch Attachment 213154 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2903255

Build Bot

Comment 3 2013-10-02 00:07:16 PDT

Comment on attachment 213154 [details] Patch Attachment 213154 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/2904315

Sam Weinig

Comment 4 2013-10-02 10:01:44 PDT

Committed r156769: <http://trac.webkit.org/changeset/156769>

Ryosuke Niwa

Comment 5 2013-10-02 11:17:59 PDT

Looks like this patch broke binding tests: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29/builds/13432/steps/bindings-generation-tests/logs/stdio

Note You need to log in before you can comment on or make changes to this bug.