Bug 122203

Summary: Move mouse event dispatch from Node to Element.
Product: WebKit Reporter: Andreas Kling <kling>
Component: UI EventsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, eflews.bot, gyuyoung.kim, kling, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+, webkit-ews: commit-queue-
Patch for landing with SVG build fix none

Description Andreas Kling 2013-10-01 20:28:00 PDT 
We don't dispatch mouse events on nodes.
Comment 1 Andreas Kling 2013-10-01 20:36:02 PDT 
Created attachment 213146 [details]
Patch
Comment 2 Early Warning System Bot 2013-10-01 20:43:27 PDT 
Comment on attachment 213146 [details]
Patch

Attachment 213146 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2905297
Comment 3 Early Warning System Bot 2013-10-01 20:45:15 PDT 
Comment on attachment 213146 [details]
Patch

Attachment 213146 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2891284
Comment 4 Darin Adler 2013-10-01 20:46:10 PDT 
Comment on attachment 213146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213146&action=review

> Source/WebCore/page/EventHandler.cpp:2247
>      m_instanceUnderMouse = instanceAssociatedWithShadowTreeElement(result);

This needs to be targetElement instead of result.
Comment 5 Andreas Kling 2013-10-01 20:46:43 PDT 
(In reply to comment #4)
> (From update of attachment 213146 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213146&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:2247
> >      m_instanceUnderMouse = instanceAssociatedWithShadowTreeElement(result);
> 
> This needs to be targetElement instead of result.

Awkward. :|
Comment 6 EFL EWS Bot 2013-10-01 20:47:55 PDT 
Comment on attachment 213146 [details]
Patch

Attachment 213146 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2903217
Comment 7 Andreas Kling 2013-10-01 20:48:28 PDT 
Created attachment 213148 [details]
Patch for landing with SVG build fix
Comment 8 WebKit Commit Bot 2013-10-01 21:18:46 PDT 
Comment on attachment 213148 [details]
Patch for landing with SVG build fix

Clearing flags on attachment: 213148

Committed r156761: <http://trac.webkit.org/changeset/156761>
Comment 9 WebKit Commit Bot 2013-10-01 21:18:49 PDT 
All reviewed patches have been landed.  Closing bug.