| Summary: | WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
| Component: | New Bugs | Assignee: | Mark Rowe (bdash) <mrowe> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Rowe (bdash)
2013-10-01 15:27:14 PDT
Created attachment 213127 [details]
Patch
Attachment 213127 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/API/c/cf/WKErrorCF.h', u'Source/WebKit2/Shared/API/c/cf/WKStringCF.h', u'Source/WebKit2/Shared/API/c/cf/WKURLCF.h', u'Source/WebKit2/Shared/API/c/cg/WKImageCG.h', u'Source/WebKit2/Shared/API/c/mac/WKURLRequestNS.h', u'Source/WebKit2/Shared/API/c/mac/WKURLResponseNS.h', u'Source/WebKit2/UIProcess/API/C/cg/WKIconDatabaseCG.h']" exit_code: 1
Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|