Bug 122181 – Please add a way to quick peek at failing tests at build.webkit.org/dashboard

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

It's good to have a way to go to complete test run results, but often, I just want a quick peek at which tests failed. Some kind of hover activated view would be helpful.

That could have links to result, and possibly to flakiness dashboard. Ideally, it would even tell me more about each test, e.g. when it started to fail, or whether it's been flaky on this bot. It could specifically note if it's a new test that was just landed in a failing state.

[Alexey Proskuryakov]

See also bug 122901.

[Alexey Proskuryakov]

Created attachment 220209 [details]
proposed patch

[Alexey Proskuryakov]

Created attachment 220210 [details]
screenshot

> That could have links to result, and possibly to flakiness dashboard. Ideally, it would even tell me more about each test, e.g. when it started to fail, or whether it's been flaky on this bot. It could specifically note if it's a new test that was just landed in a failing state.

This patch doesn't implement all wishes at once. We'll see how necessary they are when using this first iteration

[Alexey Proskuryakov]

Created attachment 220213 [details]
another screenshot

[Alexey Proskuryakov]

Created attachment 220214 [details]
proposed patch

Slightly updated JSONP load error handling. Got rid of document.write in loadJSONP().

[Alexey Proskuryakov]

Comment on attachment 220214 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220214&action=review

> Tools/ChangeLog:51
> +        enter it without a mousenter event, install a handler for mousewheel instead, and block
> +        document scrolling from this event handler when needed.

Bug 120786 tracks that we are not getting this mousewheel. I'll add a FIXME with the number when landing.

[Alexey Proskuryakov]

Comment on attachment 220214 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220214&action=review

>> Tools/ChangeLog:51
>> +        document scrolling from this event handler when needed.
> 
> Bug 120786 tracks that we are not getting this mousewheel. I'll add a FIXME with the number when landing.

this *mouseenter*

[Timothy Hatcher]

Comment on attachment 220214 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220214&action=review

> Tools/ChangeLog:47
> +        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:

We should merge these back to the Web Inspector too, if they are applicable.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:73
> +function loadJSONP(url, jsonCallbackName, callback)

Another option would be to tweak JSON.load to support an optional jsonCallbackName. Then just preprocess the result string (stripping the callback) before doing JSON.parse. That seems cleaner than creating an invisible iframe. And less likely to have XSS issues.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:77
> +    console.assert(typeof jsonCallbackName == "string");

I like to use === as much as possible.

[Alexey Proskuryakov]

> That seems cleaner than creating an invisible iframe.

Indeed! I went with invisible frame approach because these files don't have CORS headers, but since they reside on the same host, they don't need the headers.

I'll change it and post a new patch.

[Alexey Proskuryakov]

Created attachment 220322 [details]
with a better way to load JSONP

Only substantial changes are in Utilities.js.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r161273>.