Support HTML5 canvas draw{Custom,System}FocusRing()

• Component: Canvas
• Status: RESOLVED WONTFIX

[Rik Cabanier]

The Canvas spec lists 2 methods for drawing focus rings: drawSystemFocusRing and drawCustomFocusRing

http://www.w3.org/TR/2dcontext/#dom-context-2d-drawsystemfocusring
http://www.w3.org/TR/2dcontext/#dom-context-2d-drawcustomfocusring

Experimental support for these methods has landed in blink (http://src.chromium.org/viewvc/blink?view=revision&revision=155185) and I'm working on getting it submitted for Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=540456)

This seems like an easy fix. In addition, OSX seems to have a method called wkDrawFocusRing that could be used.

[Rik Cabanier]

Created attachment 213744 [details]
Patch

[Rik Cabanier]

Comment on attachment 213744 [details]
Patch

not for review. just to see if I broke something

[Build Bot]

Comment on attachment 213744 [details]
Patch

Attachment 213744 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3746297

New failing tests:
inspector/profiler/canvas2d/canvas2d-api-changes.html

[Build Bot]

Created attachment 213749 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 213744 [details]
Patch

Attachment 213744 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/3750227

New failing tests:
inspector/profiler/canvas2d/canvas2d-api-changes.html

[Build Bot]

Created attachment 213750 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 213744 [details]
Patch

Attachment 213744 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/3762031

New failing tests:
inspector/profiler/canvas2d/canvas2d-api-changes.html

[Build Bot]

Created attachment 213751 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Rik Cabanier]

Created attachment 213755 [details]
Patch

[Rik Cabanier]

Comment on attachment 213755 [details]
Patch

not for review

[chris fleizach]

Comment on attachment 213755 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213755&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:241
> +    if (m_hasExplicitRect)

I think it would be nicer if the AX code could calculate the rect when requested, rather than have it set and be updated all the time. That's what happens for most of the other AX data

[Rik Cabanier]

(In reply to comment #11)
> (From update of attachment 213755 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213755&action=review
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:241
> > +    if (m_hasExplicitRect)
> 
> I think it would be nicer if the AX code could calculate the rect when requested, rather than have it set and be updated all the time. That's what happens for most of the other AX data

I agree. Can you point me to some documentation for the AX classes or files/code where this should be changed?

[Dirk Schulze]

(In reply to comment #12)
> (In reply to comment #11)
> > (From update of attachment 213755 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=213755&action=review
> > 
> > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:241
> > > +    if (m_hasExplicitRect)
> > 
> > I think it would be nicer if the AX code could calculate the rect when requested, rather than have it set and be updated all the time. That's what happens for most of the other AX data
> 
> I agree. Can you point me to some documentation for the AX classes or files/code where this should be changed?

Any update on that?

[chris fleizach]

(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > (From update of attachment 213755 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=213755&action=review
> > > 
> > > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:241
> > > > +    if (m_hasExplicitRect)
> > > 
> > > I think it would be nicer if the AX code could calculate the rect when requested, rather than have it set and be updated all the time. That's what happens for most of the other AX data
> > 
> > I agree. Can you point me to some documentation for the AX classes or files/code where this should be changed?
> 
> Any update on that?

What are you looking for? I think in accessibilityElementRect, you would want to calculate this value on the fly rather than setting

[Rik Cabanier]

These API were renamed and some of their functionality was removed.