Bug 122175

Summary:

use adoptCOM template instead of COMPtr::adoptRef

Product:

WebKit

Reporter:

Alex Christensen <alex.christensen>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Minor

CC:

andersca, bfulgham

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	alex.christensen: review-

Alex Christensen

Reported 2013-10-01 13:06:32 PDT

Once bug 122069 lands, we'll have a syntactically better alternative to COMPtr::adoptRef, which requires two lines and is hard to distinguish from PassRefPtr's adoptRef. This should probably be a global rename in the Windows code, and COMPtr::adoptRef should be remove. Also, PassRefPtr would look nicer if it used a custom type like AdoptRefPtr instead of an unused bool in the constructor.

Attachments
Patch (15.67 KB, patch) 2013-10-17 16:07 PDT, Alex Christensen	alex.christensen: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-10-17 16:07:32 PDT

Created attachment 214528 [details] Patch

Alex Christensen

Comment 2 2013-10-17 16:13:42 PDT

Comment on attachment 214528 [details] Patch Some of these should be left as they are. adoptCOM should only replace adoptRef when the COMPtr is declared and the next line is calling adoptRef. Otherwise it changes functionality.

Brent Fulgham

Comment 3 2016-03-21 17:19:03 PDT

Alex, do you need this bug anymore? Can you revise the patch, or can we close the bug?

Note You need to log in before you can comment on or make changes to this bug.