Bug 122122 – [Mac] Add support for VideoTrack to MediaPlayerPrivateAVFObjC

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[Mac] Add support for VideoTrack to MediaPlayerPrivateAVFObjC

[Jer Noble]

Created attachment 213033 [details]
Patch

[Eric Carlson]

Comment on attachment 213033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=213033&action=review

> Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:83
> +    else

Nit: the final "else" isn't needed.

> Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:98
> +    else

Ditto.

> Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:121
> +    else

Ditto.

> Source/WebCore/platform/graphics/avfoundation/VideoTrackPrivateAVF.h:35
> +class VideoTrackPrivateAVF : public VideoTrackPrivate {

FINAL

> Source/WebCore/platform/graphics/avfoundation/VideoTrackPrivateAVF.h:42
> +    virtual Kind kind() const { return m_kind; }
> +    virtual AtomicString id() const { return m_id; }
> +    virtual AtomicString label() const { return m_label; }
> +    virtual AtomicString language() const { return m_language; }

OVERRIDE

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1134
> +void MediaPlayerPrivateAVFoundationObjC::updateVideoTracks()

This looks *awfully* similar to updateAudioTracks. Is there any way to share code like MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks does for processing in-band text tracks?

> Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:40
> +class VideoTrackPrivateAVFObjC : public VideoTrackPrivateAVF {

FINAL

> Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:48
> +    virtual void setSelected(bool);

OVERRIDE

> LayoutTests/media/track/video-track.html:37
> +            function canplaythrough()
> +            {
> +                consoleWrite("<br><i>** Check initial in-band track states<" + "/i>");
> +                testExpected("video.videoTracks.length", 1);
> +
> +                consoleWrite("<br><i>** Unload video file, check track count<" + "/i>");
> +                run("video.src = ''");
> +                testExpected("video.videoTracks.length", 0);
> +
> +                consoleWrite("");
> +                endTest();
> +            }

This should also test the "only one video track enabled" spec requirement.

[Jer Noble]

Committed r156722: <http://trac.webkit.org/changeset/156722>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 122171

[Jer Noble]

In the end, the rollout was not necessary. Moving back to Resolved/Fixed.