Bug 122108

Summary:

Web Inspector: rows in the Layer sidebar panel may have the incorrect background color

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Web Inspector

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Antoine Quint 2013-09-30 07:53:30 PDT

Since LayerTreeDataGrid sorts its nodes in a custom way with a .setChildren() method, where we don't touch the DOM structure, but rather change the transforms on the nodes, then the styling applied based on DOM order doesn't work. We'll need to do this manually.

Comment 1 Radar WebKit Bug Importer 2013-09-30 07:53:40 PDT

<rdar://problem/15111014>

Comment 2 Antoine Quint 2013-09-30 07:54:26 PDT

<rdar://problem/14101458>

Comment 3 Antoine Quint 2013-09-30 08:00:42 PDT

Created attachment 212994 [details]
Patch

Comment 4 Darin Adler 2013-09-30 11:40:14 PDT

Comment on attachment 212994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212994&action=review

> Source/WebInspectorUI/UserInterface/LayerTreeDataGrid.js:101
> +            if (i % 2 === 1) {

I think we can leave off the “=== 1” here, since it’s just zero vs. non-zero.

Comment 5 Antoine Quint 2013-09-30 12:37:21 PDT

Created attachment 213025 [details]
Patch for landing

Comment 6 WebKit Commit Bot 2013-09-30 13:08:59 PDT

Comment on attachment 213025 [details]
Patch for landing

Clearing flags on attachment: 213025

Committed r156675: <http://trac.webkit.org/changeset/156675>

Comment 7 WebKit Commit Bot 2013-09-30 13:09:01 PDT

All reviewed patches have been landed.  Closing bug.