Bug 122108

Summary: Web Inspector: rows in the Layer sidebar panel may have the incorrect background color
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Web InspectorAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2013-09-30 07:53:30 PDT
Since LayerTreeDataGrid sorts its nodes in a custom way with a .setChildren() method, where we don't touch the DOM structure, but rather change the transforms on the nodes, then the styling applied based on DOM order doesn't work. We'll need to do this manually.
Attachments
Patch (3.75 KB, patch)
2013-09-30 08:00 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.75 KB, patch)
2013-09-30 12:37 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-09-30 07:53:40 PDT
<rdar://problem/15111014>
Antoine Quint
Comment 2 2013-09-30 07:54:26 PDT
<rdar://problem/14101458>
Antoine Quint
Comment 3 2013-09-30 08:00:42 PDT
Created attachment 212994 [details] Patch
Darin Adler
Comment 4 2013-09-30 11:40:14 PDT
Comment on attachment 212994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212994&action=review > Source/WebInspectorUI/UserInterface/LayerTreeDataGrid.js:101 > + if (i % 2 === 1) { I think we can leave off the “=== 1” here, since it’s just zero vs. non-zero.
Antoine Quint
Comment 5 2013-09-30 12:37:21 PDT
Created attachment 213025 [details] Patch for landing
WebKit Commit Bot
Comment 6 2013-09-30 13:08:59 PDT
Comment on attachment 213025 [details] Patch for landing Clearing flags on attachment: 213025 Committed r156675: <http://trac.webkit.org/changeset/156675>
WebKit Commit Bot
Comment 7 2013-09-30 13:09:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.