Bug 122103 – [EFL] Changed expectation for accessibility/file-upload-button-stringvalue.html after r156532

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Krzysztof Czech]

Changed actual value from "(None)" to "No file selected" and "No files selected"

[Krzysztof Czech]

Created attachment 212993 [details]
Patch

[Mario Sanchez Prada]

Comment on attachment 212993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212993&action=review

> LayoutTests/platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt:11
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: file1.txt
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: file1.txt
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected

Hrm... this is strange. It should keep reporting file1.txt here, instead of "No files selected". If that's not the case, and previously it used to output file1.txt for EFL-WK1, then there's a bug and the rebaseline would not be correct.

> LayoutTests/platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt:15
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: (None)
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: 2 files
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected

Same here. The "No files selected" part is probably right (assuming is what you see rendered on the browser besides the button when no selection has been made yet), but the change from "2 files" -> "No files selected" is definitely wrong and it's probably hiding a bug in EFL (it's working fine in GTK)

> LayoutTests/platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt:15
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: (None)
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: (None)
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected
>  
>  Drag and drop a single file:
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: (None)
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: (None)
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected
>  
>  Drag and drop two files:
> -accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: (None)
> -accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: (None)
> +accessibilityController.accessibleElementById("singleFileUpload").stringValue: AXValue: No file selected
> +accessibilityController.accessibleElementById("multipleFileUpload").stringValue: AXValue: No files selected

These ones are probably right (again, assuming is what you see rendered on the browser besides the button when no selection has been made yet), since this test that not work ok in any platform yet, as far as I know

[Krzysztof Czech]

> Same here. The "No files selected" part is probably right (assuming is what you see rendered on the browser besides the button when no selection has been made yet), but the change from "2 files" -> "No files selected" is definitely wrong and it's probably hiding a bug in EFL (it's working fine in GTK)
> 

I checked that. It not a bug, there a missing implementation of beginDragWithFiles in EventSender. I guess this is a reason.
I will opened a bug on efl-wk1 regarding this.

Tnahks.

[Krzysztof Czech]

> Tnahks.
Thanks

[Krzysztof Czech]

Created attachment 213001 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 213001 [details]
Patch

Clearing flags on attachment: 213001

Committed r156659: <http://trac.webkit.org/changeset/156659>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.