Bug 122096

Summary:

[EFL] Gardening after the resolution of bug 84835

Product:

WebKit

Reporter:

Rob Płóciennik <r.plociennik>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, g.czajkowski, gyuyoung.kim, lucas.de.marchi, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	commit-queue: commit-queue-
Yet another attempt at submitting the proposed patch.	none

Rob Płóciennik

Reported 2013-09-30 02:58:24 PDT

Removed expected failures for bug 84835. editing/pasteboard/copy-inside-h1-preserves-h1 and editing/pasteboard/copy-without-selection are still failing due to bug 86623 and have been marked accordingly.

Attachments
Proposed patch (2.98 KB, patch) 2013-09-30 03:06 PDT, Rob Płóciennik	no flags	Details Formatted Diff Diff
Proposed patch (2.98 KB, patch) 2013-09-30 03:18 PDT, Rob Płóciennik	commit-queue: commit-queue-	Details Formatted Diff Diff
Yet another attempt at submitting the proposed patch. (2.98 KB, patch) 2013-09-30 04:11 PDT, Rob Płóciennik	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Rob Płóciennik

Comment 1 2013-09-30 03:06:57 PDT

Created attachment 212970 [details] Proposed patch

WebKit Commit Bot

Comment 2 2013-09-30 03:08:16 PDT

Attachment 212970 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl-wk1/TestExpectations', u'LayoutTests/platform/efl/TestExpectations']" exit_code: 1 LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Rob Płóciennik

Comment 3 2013-09-30 03:18:33 PDT

Created attachment 212973 [details] Proposed patch

WebKit Commit Bot

Comment 4 2013-09-30 04:01:15 PDT

Comment on attachment 212973 [details] Proposed patch Rejecting attachment 212973 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 212973, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/2640167

Rob Płóciennik

Comment 5 2013-09-30 04:11:04 PDT

Created attachment 212975 [details] Yet another attempt at submitting the proposed patch.

Grzegorz Czajkowski

Comment 6 2013-09-30 04:17:51 PDT

Comment on attachment 212975 [details] Yet another attempt at submitting the proposed patch. Thanks for the changes!

WebKit Commit Bot

Comment 7 2013-09-30 04:48:03 PDT

Comment on attachment 212975 [details] Yet another attempt at submitting the proposed patch. Clearing flags on attachment: 212975 Committed r156646: <http://trac.webkit.org/changeset/156646>

WebKit Commit Bot

Comment 8 2013-09-30 04:48:06 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.