Bug 122080

Summary:

Get rid of static map for marking ancestor line boxes dirty

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion	none
patch	none
another	none

Antti Koivisto

Reported 2013-09-29 16:26:32 PDT

It is slow too.

Attachments
patch (12.59 KB, patch) 2013-09-29 16:33 PDT, Antti Koivisto	kling: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (914.24 KB, application/zip) 2013-09-29 17:31 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (926.59 KB, application/zip) 2013-09-29 17:52 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (926.22 KB, application/zip) 2013-09-29 18:49 PDT, Build Bot	no flags	Details
patch (12.01 KB, patch) 2013-09-29 20:17 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
another (12.36 KB, patch) 2013-09-29 20:48 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2013-09-29 16:33:13 PDT

Created attachment 212937 [details] patch

Andreas Kling

Comment 2 2013-09-29 16:40:59 PDT

Comment on attachment 212937 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=212937&action=review r=me > Source/WebCore/rendering/RenderElement.h:132 > + bool m_ancestorLineBoxDirty : 1; Now would be a good time to add a compile-time assertion for sizeof(RenderElement)! > Source/WebCore/rendering/RenderLineBoxList.h:67 > + void dirtyLinesFromChangedChild(RenderBlockFlow* parent, RenderObject* child); 'parent' could be a RenderBlockFlow& here. NABD.

Build Bot

Comment 3 2013-09-29 17:31:27 PDT

Comment on attachment 212937 [details] patch Attachment 212937 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2696118 New failing tests: platform/mac/editing/spelling/autocorrection-blockquote-crash.html editing/pasteboard/paste-text-with-style-4.html editing/deleting/delete-tab-004.html editing/pasteboard/copy-backslash-with-euc.html editing/inserting/insert-div-022.html editing/inserting/insert-br-002.html editing/inserting/insert-tab-004.html editing/inserting/typing-around-br-001.html editing/deleting/5272440.html editing/inserting/insert-br-at-tabspan-001.html editing/deleting/delete-ws-fixup-002.html editing/style/style-3690704-fix.html editing/pasteboard/3976872.html editing/inserting/insert-paragraph-with-font-and-background-color.html editing/inserting/insert-br-004.html editing/pasteboard/drop-text-events.html fast/forms/paste-multiline-text-input.html js/dom/text-field-resize.html editing/inserting/insert-br-at-tabspan-002.html

Build Bot

Comment 4 2013-09-29 17:31:28 PDT

Created attachment 212938 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2013-09-29 17:52:08 PDT

Comment on attachment 212937 [details] patch Attachment 212937 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2708108 New failing tests: platform/mac/editing/spelling/autocorrection-blockquote-crash.html editing/pasteboard/paste-text-with-style-4.html editing/deleting/delete-tab-004.html editing/pasteboard/copy-backslash-with-euc.html editing/inserting/insert-div-022.html editing/inserting/insert-br-002.html editing/inserting/insert-tab-004.html editing/inserting/typing-around-br-001.html editing/deleting/5272440.html editing/inserting/insert-br-at-tabspan-001.html editing/deleting/delete-ws-fixup-002.html editing/style/style-3690704-fix.html editing/pasteboard/3976872.html editing/inserting/insert-paragraph-with-font-and-background-color.html editing/inserting/insert-br-004.html editing/pasteboard/drop-text-events.html fast/forms/paste-multiline-text-input.html js/dom/text-field-resize.html editing/inserting/insert-br-at-tabspan-002.html

Build Bot

Comment 6 2013-09-29 17:52:09 PDT

Created attachment 212939 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2013-09-29 18:49:10 PDT

Comment on attachment 212937 [details] patch Attachment 212937 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2710127 New failing tests: platform/mac/editing/spelling/autocorrection-blockquote-crash.html editing/pasteboard/paste-text-with-style-4.html editing/deleting/delete-tab-004.html editing/pasteboard/copy-backslash-with-euc.html editing/inserting/insert-div-022.html editing/inserting/insert-br-002.html editing/inserting/insert-tab-004.html editing/inserting/typing-around-br-001.html editing/deleting/5272440.html editing/inserting/insert-br-at-tabspan-001.html editing/deleting/delete-ws-fixup-002.html editing/style/style-3690704-fix.html editing/pasteboard/3976872.html editing/inserting/insert-paragraph-with-font-and-background-color.html editing/inserting/insert-br-004.html editing/pasteboard/drop-text-events.html fast/forms/paste-multiline-text-input.html js/dom/text-field-resize.html editing/inserting/insert-br-at-tabspan-002.html

Build Bot

Comment 8 2013-09-29 18:49:12 PDT

Created attachment 212942 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Antti Koivisto

Comment 9 2013-09-29 20:17:30 PDT

Created attachment 212945 [details] patch

Antti Koivisto

Comment 10 2013-09-29 20:48:06 PDT

Created attachment 212946 [details] another

Antti Koivisto

Comment 11 2013-09-30 01:20:50 PDT

https://trac.webkit.org/r156639

Note You need to log in before you can comment on or make changes to this bug.